From owner-freebsd-multimedia@FreeBSD.ORG  Thu Feb 22 17:55:46 2007
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
X-Original-To: multimedia@freebsd.org
Delivered-To: freebsd-multimedia@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7E16216A405
	for <multimedia@freebsd.org>; Thu, 22 Feb 2007 17:55:46 +0000 (UTC)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 692D713C474
	for <multimedia@freebsd.org>; Thu, 22 Feb 2007 17:55:45 +0000 (UTC)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id l1MHthmK007741;
	Thu, 22 Feb 2007 09:55:43 -0800 (PST)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.11/8.12.3/Submit) id l1MHthvU007740;
	Thu, 22 Feb 2007 09:55:43 -0800 (PST) (envelope-from rizzo)
Date: Thu, 22 Feb 2007 09:55:43 -0800
From: Luigi Rizzo <rizzo@icir.org>
To: Jeremy Messenger <mezz7@cox.net>
Message-ID: <20070222095543.A7555@xorpc.icir.org>
References: <20070221073447.A89386@xorpc.icir.org>
	<op.tn31gkon9aq2h7@mezz.mezzweb.com>
	<20070221095911.D90766@xorpc.icir.org>
	<op.tn34fuds9aq2h7@mezz.mezzweb.com>
	<20070221112414.E91427@xorpc.icir.org>
	<op.tn372ibm9aq2h7@mezz.mezzweb.com>
	<op.tn4hkoua9aq2h7@mezz.mezzweb.com>
	<20070221160312.A94968@xorpc.icir.org>
	<op.tn5vkdeh9aq2h7@mezz.mezzweb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <op.tn5vkdeh9aq2h7@mezz.mezzweb.com>;
	from mezz7@cox.net on Thu, Feb 22, 2007 at 11:44:27AM -0600
Cc: multimedia@freebsd.org
Subject: Re: speex upgrade to 1.1.12 ?
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2007 17:55:46 -0000

On Thu, Feb 22, 2007 at 11:44:27AM -0600, Jeremy Messenger wrote:
...
> > http://info.iet.unipi.it/~luigi/FreeBSD/speex-devel-20070221.tgz
> 
> Why remove two patches? They are not need anymore? I can build with two  

apparently yes they are not needed anymore.

> patches w/out any of problem. As for the Makefile, I have done a bit tweak  
>  from your changes. Example:
> -PORTVERSION -> DISTVERSION.
> -CONFLICTS=speex-*, this is incorrect and is too general. It should be  
> speex-[0-9]*.
> -Remove 'devel version' and peroid. An end of peroid in the sentence is  
> illegal in COMMENT.
> -INSTALLS_SHLIB -> USE_LDCONFIG.
> -CONFIGURE_TARGET -> USE_GNOME=gnometarget
> -Add USE_GNOME=ltverhack to avoid shared library version bump to often by  
> fix libtool bug.
> -Add CONFIGURE_ENV by add -I/-L${LOCALBASE}/[...] to make it works when  
> install speex in the different prefix.

fine, most of the things you note below were just inherited from
the previous one (PORTVERSION, CONFIGURE_TARGET, INSTALL_SHLIBS).

> -Remove MAKE_ENV, I don't think it is need.

LDFLAGS was added because some of the code uses the math library and
	-lm is not included by default on my box at least (RELENG_6).
	Maybe some of the other changes you made also imply -lm ?

CFLAGS were just added to build with stricter compiler flags,
	so it is not strictly necessary;

> 
> I am not done (have to go back to class soon) with it yet, so if you have  
> any of question then let me know.

nothing else.

cheers
luigi