From owner-svn-src-all@freebsd.org Fri Jan 20 06:43:27 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63C74CB92A4; Fri, 20 Jan 2017 06:43:27 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E49E0126B; Fri, 20 Jan 2017 06:43:26 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wm0-f65.google.com with SMTP id r126so4324632wmr.3; Thu, 19 Jan 2017 22:43:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=TN6e0m4WW6GIcNbV7B9BtXRrqIG6OKUjGfw4lkUo+TA=; b=fshRbIKg6afmx1RLSi3cvbuVIbr+FMwHZozEPMM7AmICEECwwYscHQOhpfilUvh50F v6QAxm0nMiLS6KXIKvnmWe69Xjcx3aOBrtVAuHDZ1C/UTU2X2CrI4vZpDD8usp68mxld EbEs916Auc/MMZQIb3Q0NPFgwfifQUGCweXQHf4LbuZ/YtX8QXur8NDnA4ret0F49WGM cXNcshUPEgE/9K4FX1LoAZkGf7aFPZZcWyi2xzbS+6fXKHT/C93jMWnZ3yr1eS/miE0T 9lVuyb3FL6ppzEd+bq31Wbbs5scYUjjdW7l/0EYbVvLbNuWABam4VUlOVMMq6kTjKZoa V42Q== X-Gm-Message-State: AIkVDXIcwKLJC0vsVCh4faE/e8/FMob4/rrMz/feRh/uvA2YrO9jksa0sELfCgfYaT5sVw== X-Received: by 10.28.34.194 with SMTP id i185mr1905677wmi.118.1484894217655; Thu, 19 Jan 2017 22:36:57 -0800 (PST) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com. [74.125.82.52]) by smtp.gmail.com with ESMTPSA id 191sm3765749wmo.21.2017.01.19.22.36.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jan 2017 22:36:57 -0800 (PST) Received: by mail-wm0-f52.google.com with SMTP id c206so28643674wme.0; Thu, 19 Jan 2017 22:36:57 -0800 (PST) X-Received: by 10.28.100.70 with SMTP id y67mr1840509wmb.45.1484894217406; Thu, 19 Jan 2017 22:36:57 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.194.29.72 with HTTP; Thu, 19 Jan 2017 22:36:56 -0800 (PST) In-Reply-To: References: <201701190801.v0J81ZG9008267@repo.freebsd.org> From: Conrad Meyer Date: Thu, 19 Jan 2017 22:36:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r312404 - head/usr.bin/sed To: Antoine Brodin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 06:43:27 -0000 On Thu, Jan 19, 2017 at 10:29 PM, Antoine Brodin wrot= e: > On Thu, Jan 19, 2017 at 9:01 AM, Xin LI wrote: >> Author: delphij >> Date: Thu Jan 19 08:01:35 2017 >> New Revision: 312404 >> URL: https://svnweb.freebsd.org/changeset/base/312404 >> >> Log: >> Use S_ISREG instead of manual & (also it's better to compare the >> result from & and the pattern instead of just assuming it's one bit >> value). >> >> Pointed out by Tianjie Mao . >> >> MFC after: 2 weeks >> Differential Revision: https://reviews.freebsd.org/D4827 > > Hi, > > sed -i no longer works on symlinks which breaks lots of ports. > Please revert and request an exp-run. That is clearly the intent of the code in question. It was a bug that it worked before =E2=80=94 S_IFLNK and S_IFSOCK just happen to have the S_IFREG bit set. It seems like either such ports should be fixed to dereference the link manually, or the check should be removed entirely. Best, Conrad