From owner-cvs-all  Sat Feb  1  5:17: 2 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 44AE237B401; Sat,  1 Feb 2003 05:17:01 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F293A43FA3; Sat,  1 Feb 2003 05:16:59 -0800 (PST)
	(envelope-from phk@freebsd.org)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h11DGn4W017971;
	Sat, 1 Feb 2003 14:16:49 +0100 (CET)
	(envelope-from phk@freebsd.org)
To: Jon Mini <mini@freebsd.org>
Cc: Julian Elischer <julian@elischer.org>,
	"M. Warner Losh" <imp@bsdimp.com>, jhb@freebsd.org,
	cvs-committers@freebsd.org, cvs-all@freebsd.org, tjr@freebsd.org
Subject: Re: cvs commit: src/sys/kern subr_trap.c 
From: phk@freebsd.org
In-Reply-To: Your message of "Sat, 01 Feb 2003 04:37:28 PST."
             <20030201123728.GV27470@elvis.mu.org> 
Date: Sat, 01 Feb 2003 14:16:49 +0100
Message-ID: <17970.1044105409@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <20030201123728.GV27470@elvis.mu.org>, Jon Mini writes:
>phk@freebsd.org [phk@freebsd.org] wrote :
>
>> Well, considering that you have to:
>> 
>> 	Generate backout patch.
>> 	Test it on at least:
>> 		i386/UP
>> 		i386/SMP
>> 		alpha/UP
>> 		alpha/SMP
>> 		sparc64 (has no UP/SMP split)
>> 	Commit it.
>
>Woah.. 
>We need to test backouts?
>
>Doesn't that seem a bit extreme?

A backout is no less a commit than a normal commit.  Considering that
Julian har probably barely seen the patch he is now backing out, I
would think that a normal test would be the minimum he should do.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message