From owner-freebsd-current  Wed Feb 28 20:40:16 2001
Delivered-To: freebsd-current@freebsd.org
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP id ADF3837B71B
	for <freebsd-current@FreeBSD.org>; Wed, 28 Feb 2001 20:40:10 -0800 (PST)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.1/8.11.1) with ESMTP id f214e1d45348;
	Wed, 28 Feb 2001 21:40:08 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Message-Id: <200103010440.f214e1d45348@harmony.village.org>
To: igorr@crosswinds.net
Subject: Re: Correct size of kinfo_proc 
Cc: freebsd-current@FreeBSD.org
In-reply-to: Your message of "Wed, 28 Feb 2001 16:10:09 +0300."
		<20010228161009.B14235@linux.rainbow> 
References: <20010228161009.B14235@linux.rainbow>  <3A9CF680.563D9F2B@FreeBSD.org> 
Date: Wed, 28 Feb 2001 21:40:01 -0700
From: Warner Losh <imp@harmony.village.org>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <20010228161009.B14235@linux.rainbow> Igor Robul writes:
: On Wed, Feb 28, 2001 at 03:00:48PM +0200, Maxim Sobolev wrote:
: > Hi Poul,
: > 
: > In revision 1.31 of src/sys/sys/user.h you have added new ki_layout field to
: > kinfo_proc structure, but forgot to increase KINFO_PROC_SIZE  from 644 to 648.
: > Please correct.
: Why don't use sizeof() insead of hardcoding numbers? 

Because KINFO_PROC_SIZE is part of the ABI.  Changes to its size are
always wrong, in that they break the ABI.  The checks are there to
tell us when the ABI has been broken.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message