From owner-svn-src-all@FreeBSD.ORG Mon Nov 2 10:24:05 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C90AA106566B; Mon, 2 Nov 2009 10:24:05 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id 681CA8FC12; Mon, 2 Nov 2009 10:24:05 +0000 (UTC) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 762BE1CD0A; Mon, 2 Nov 2009 11:24:04 +0100 (CET) Date: Mon, 2 Nov 2009 11:24:04 +0100 From: Ed Schouten To: David Malone Message-ID: <20091102102404.GP1293@hoeg.nl> References: <200910311035.n9VAZfIb082932@svn.freebsd.org> <20091031.190353.-332187386.imp@bsdimp.com> <20091101011212.GG1293@hoeg.nl> <20091102100435.GA67211@walton.maths.tcd.ie> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BXjkYym6qfApNY5c" Content-Disposition: inline In-Reply-To: <20091102100435.GA67211@walton.maths.tcd.ie> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, "M. Warner Losh" Subject: Re: svn commit: r198706 - head/sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2009 10:24:05 -0000 --BXjkYym6qfApNY5c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello David, * David Malone wrote: > Surely it is an API change, but not an ABI change? Code that used > to do: >=20 > d.d_uid =3D 3; >=20 > will no longer compile, but code that was comipled with the old > version will still run. I understand that the assignment doesn't > do anything useful, but I suppose there still could be code that > does it? Yes, in theory there could be pieces of code that do that, but keep in mind that d_uid was never meant to be used by device drivers. It was used by devfs internally, before cdevpriv existed. Looking at the SVN logs, it was introduced in March 2005, but it was already rendered useless in September that same year, when devfs was modified to just obtain the ownership/modes from the cdevpriv instead of the cdevsw. Interesting commits: - http://svn.freebsd.org/viewvc/base?view=3Drevision&revision=3D143746 - http://svn.freebsd.org/viewvc/base?view=3Drevision&revision=3D150342 --=20 Ed Schouten WWW: http://80386.nl/ --BXjkYym6qfApNY5c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkrus0QACgkQ52SDGA2eCwUlKwCdG75s+oKDvQJLRpiEgWUpC5By QJ0AniOiL7vUESGkSnqFOsxOWNq0LdK3 =EgKL -----END PGP SIGNATURE----- --BXjkYym6qfApNY5c--