From nobody Tue Feb 24 03:17:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fKjZz06x8z6Ss5v for ; Tue, 24 Feb 2026 03:17:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fKjZy3xLrz3DZX for ; Tue, 24 Feb 2026 03:17:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771903066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JnXl9Tq7G8ssLjwLdijDjrh6nTLc4yZKIhZ9xZUH0+Y=; b=LbPKq1QtqTB7MRvcE8u2BiXUKDaw6xDHmIsWfFVkmfW6KW8MM7UDrkF4BFdwMB73nrvcIy n55jqky0KhORmNkAxJR52PMLAiZFiBSwDCNjDZNoi21lam7EIY2ubdiPmptPrLu1JXto9y morabzM3KOJPoEzjtpZ/Lor6M4I55GzVNbOTAnmE0o+8g1xXBHjPXu4zHnGFiR7oHP8M/V rDHpBlaEynHRsKa5ByjLhySKcxNXPXtpf7nonyQT/ydjJUTX+RSNFQUfiCShRSOUA13GTg icC9+RKAi6DwG+3p2bddKMeCyky2V0Hp+lxxOyTaHh58mY4fGkXqPJwJSG+9cQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771903066; a=rsa-sha256; cv=none; b=eAEgi4vwCCGAZ4GUJPdFhqe7bTeV+VCDJyGJCCwua9zorqZApxT6uvBG/23lzYkZ6beogv tCHXbsduAquyYGFPY/gkWLYhyhtFdrP21tFvC/kToXyCLDvTxpnt8O4+eX9k2sQzwakiGN asYfMTuIMqsq32p2rsAZmCoKe5O71ZLJ/tMM0D7O9eMZWcKMz7OKx46P8d/FEhlPGAlPb7 QZeOAt2VXY29HE2OMzn9c9I58p3YbjENwYJ/1odJNvQm24C5Ns+LYMRbXIsgbMDQbRcSj5 +CjufxHCdtBaAibbyLwfK7bGgaoXvXBPFkqDUEvPbvG4Q4lXMq+lN/l1Pg31Mw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771903066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JnXl9Tq7G8ssLjwLdijDjrh6nTLc4yZKIhZ9xZUH0+Y=; b=sKI2RA4mXJL5Ecz6oGvF6JfPpnUEsAOgepKLz/xgnHw4AE2ASaEFJKqIeJ3rqk8/Kz1RfH 4OMbDrfXv4/8wzuVKA6TXh2Ckl4cCI+Cp+2L8eIdslJ9bV54RCo6RpptMPuoeTlX51CqFc cUfEuM/qsr6gEZL+T1YUcc2KF7BEjUeO8eHw9PAZIdRWdPIgeJQPuw901yzsLa3iP0aozM uk+M6gGeb6/yLaBiU0GE2+wF8gpA3TxtrhuRf5cIwJ5Am/CDt382Ya0h3aHU6B1QohCik+ t5HOPf2DeUMNxv40P8+tsShsVO/Dbx2b0ug322q4ehNcUD/qSFibRkAlVlA7RA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fKjZy3Fz4zy62 for ; Tue, 24 Feb 2026 03:17:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 263f9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Feb 2026 03:17:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: John Baldwin From: Cy Schubert Subject: git: 1ce195ddf8a6 - stable/14 - heimdal: Pass the correct pointer to realloc when growing a string buffer List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1ce195ddf8a6f92da597b400905a233deffa2cf4 Auto-Submitted: auto-generated Date: Tue, 24 Feb 2026 03:17:46 +0000 Message-Id: <699d185a.263f9.1bc749cd@gitrepo.freebsd.org> The branch stable/14 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=1ce195ddf8a6f92da597b400905a233deffa2cf4 commit 1ce195ddf8a6f92da597b400905a233deffa2cf4 Author: John Baldwin AuthorDate: 2026-02-02 17:18:11 +0000 Commit: Cy Schubert CommitDate: 2026-02-24 03:17:35 +0000 heimdal: Pass the correct pointer to realloc when growing a string buffer The realloc in my_fgetln was trying to grow the pointer to the string buffer, not the string buffer itself. In function 'my_fgetln', inlined from 'mit_prop_dump' at crypto/heimdal/kdc/mit_dump.c:156:19: crypto/heimdal/kdc/mit_dump.c:119:13: error: 'realloc' called on unallocated object 'line' [-Werror=free-nonheap-object] 119 | n = realloc(buf, *sz + (*sz >> 1)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ crypto/heimdal/kdc/mit_dump.c: In function 'mit_prop_dump': crypto/heimdal/kdc/mit_dump.c:139:11: note: declared here 139 | char *line = NULL; | ^~~~ Reviewed by: rmacklem, cy Fixes: a93e1b731ae4 ("heimdal-kadmin: Add support for the -f dump option") Differential Revision: https://reviews.freebsd.org/D54933 (cherry picked from commit 03d8ac948b1ad9c419b294c3129b7da58d818363) --- crypto/heimdal/kdc/mit_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/kdc/mit_dump.c b/crypto/heimdal/kdc/mit_dump.c index 4397d1ad897d..d790b145af11 100644 --- a/crypto/heimdal/kdc/mit_dump.c +++ b/crypto/heimdal/kdc/mit_dump.c @@ -116,7 +116,7 @@ my_fgetln(FILE *f, char **buf, size_t *sz, size_t *len) return 0; } *len += strlen(&(*buf)[*len]); /* *len should be == *sz */ - n = realloc(buf, *sz + (*sz >> 1)); + n = realloc(*buf, *sz + (*sz >> 1)); if (!n) { free(*buf); *buf = NULL;