From owner-cvs-src@FreeBSD.ORG Mon Jan 14 22:32:55 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E0B216A41B; Mon, 14 Jan 2008 22:32:55 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.freebsd.org (Postfix) with ESMTP id 41E9113C447; Mon, 14 Jan 2008 22:32:54 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.14.2/8.14.1) with ESMTP id m0EMWeaS056440; Mon, 14 Jan 2008 17:32:40 -0500 (EST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.14.2/8.14.1/Submit) id m0EMWdwk056439; Mon, 14 Jan 2008 17:32:40 -0500 (EST) (envelope-from das@FreeBSD.ORG) Date: Mon, 14 Jan 2008 17:32:39 -0500 From: David Schultz To: Kris Kennaway Message-ID: <20080114223239.GC56062@VARK.MIT.EDU> Mail-Followup-To: Kris Kennaway , obrien@FreeBSD.ORG, Tim Kientzle , Tim Kientzle , Dag-Erling Smorgrav , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <478BC55B.2060202@FreeBSD.org> Cc: Tim Kientzle , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, obrien@FreeBSD.ORG, Tim Kientzle , cvs-all@FreeBSD.ORG, Dag-Erling Smorgrav Subject: Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 22:32:55 -0000 On Mon, Jan 14, 2008, Kris Kennaway wrote: > David O'Brien wrote: > > >>If we have to special case ports to deal with variant zipfiles that > >>cannot be processed by /usr/bin/unzip then it gets messier because we > >>have to account for some ports being satisfied with USE_ZIP=yes meaning > >>/usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd > >>prefer not to have to add those workarounds. > > > >This seems quite easy... > > > >For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' > > That's what I meant by "special case". I don't like adding special case > variables to bsd.*.mk for the benefit of a tiny number of ports; that > file is already cluttered enough. Given how little time it took Tim to get libarchive from a simple prototype that supported tar files to a 23k line library that supports dozens of variant archive formats, I suspect that the limitation and the corresponding hack will be temporary. :) And if it is just a small number of ports, it could be set up as an extract dependency in the individual port makefiles, right? It's not as though InfoZIP is going to change a lot in the near future.