From owner-svn-ports-all@freebsd.org Wed Mar 28 18:58:41 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90A1CF702C7; Wed, 28 Mar 2018 18:58:41 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4795B7DC78; Wed, 28 Mar 2018 18:58:41 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 4108611474; Wed, 28 Mar 2018 18:58:41 +0000 (UTC) Date: Wed, 28 Mar 2018 18:58:41 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r465830 - head/astro/stellarium Message-ID: <20180328185841.GA93245@FreeBSD.org> References: <201803281720.w2SHKmHU086890@repo.freebsd.org> <20180328172437.GA20977@FreeBSD.org> <20180328180646.aqml7rdmr773xiot@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180328180646.aqml7rdmr773xiot@ogg.in.absolight.net> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 18:58:41 -0000 On Wed, Mar 28, 2018 at 08:06:46PM +0200, Mathieu Arnold wrote: > On Wed, Mar 28, 2018 at 05:24:37PM +0000, Alexey Dokuchaev wrote: > > On Wed, Mar 28, 2018 at 05:20:48PM +0000, Alexey Dokuchaev wrote: > > > New Revision: 465830 > > > URL: https://svnweb.freebsd.org/changeset/ports/465830 > > > > > > Log: > > > - Update `astro/stellarium' to version 0.18.0 > > > - TIMESTAMP (Stellarium-stellarium-v0.17.0_GH0.tar.gz) = 1521967282 > > ^^^^^^ > > Ah, sorry, I've fucked up, it should read 0.18.0. TIMESTAMP logic should > > really be fixed so we won't have to reiterate it in the commit logs. :-( > > It was decided that the TIMESTAMP logic would work as it currently does, > so these lines you add to your commit messages are really not needed. Current logic is both confusing and redundant, as it adds yet another timestamp to already existing distfile(s) timestamp and commit timestamp. Per my understanding, it was only put in place because of Git, which does not support keyword expansion. Personally I don't understand why would we want to support a crippled VCS, but before I figure a way out of this, I feel that proper TIMESTAMP metainfo should either go to commit message, or be recorded elsewhere. ./danfe