From owner-svn-src-all@freebsd.org Mon Feb 25 15:12:19 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20A1D150D0D4; Mon, 25 Feb 2019 15:12:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 915FE6A491; Mon, 25 Feb 2019 15:12:18 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x531.google.com with SMTP id l11so4609928pgq.10; Mon, 25 Feb 2019 07:12:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=doMXmR4A5cks1QLONFf+cMOkPs26pCx0nI8svub5muE=; b=Jx3QD4OVkDcrfm9vk6oLMQ7UdWBhpOY94952t4K7lyXmAWICyZ8r2wo6AIIMtbmKVX 70yM9s24uDwMR/lp+Z+14k0/gKH+6jypVdzHxaRQTAxKwzZ/eW9Jss/vowBlQ7Do/BTc a22Ahxshz3w9U9FfF5zFgWZRkzfmjQ5HXvzTCaCE0LiaNVB9kKMWRSZKoj66jPpaE+BL Eq0Gu8o8o3zoqRiOd4/jjyf86SL98wkHoJFeiXRDBm1+zk41RmnBkB3saxvfdbULdnOx Z2HX/+0QZ+NVEc3xgu/L6zD8XmaC+BBHrk7CbP5qUuva7sDNrTOcS4RC6RLGlhQY8Crk F3Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=doMXmR4A5cks1QLONFf+cMOkPs26pCx0nI8svub5muE=; b=rN5Zj+oIwg6HTGcSgQTq5VFsXMxazOxJAL6sbC55GfdQt6xYFZY2nbun1ApxD3T2bD 9CRArzrVXxrkO7f4x8OHHRJpiC7CWqAV6Yvq4oVnORZ4aRSCeNeHCTxbHUj9zi5ahHPV 9As6XbzLR6qsgm1v/0FWQZvJZym95bd3ClEe5d5Ylw7u5rccNHFXXJ9ik78RDJBmyEW6 Lj2S+G1p2A/Nd30fIr8nP5FrpfE77D2oHCpJOdjuExaI3HlsLnzhD9sJfnZ/WjRLzdhJ WL8zy3EdWG5UGxusOCR+aM7fVvHGaT1wfxK2jki3NB5P69mHEhUKxdD9SiCCBB39Nd9R ADJQ== X-Gm-Message-State: AHQUAuaW2/M6R3gGtjTb2Clb94LoVAcN5V5iERBPlbQXzXesuUodDYfk u8KWnSSCsrD+u7BPfpwUXtO8c7tL X-Google-Smtp-Source: AHgI3IaZcFTpnT3lu8ZNwn4hR9tNH2qSKZH9JyR+e5fNhqQfUrP4vSYBzkS6CyzO5SYj0P8krP+3Bg== X-Received: by 2002:a63:2c7:: with SMTP id 190mr18555758pgc.367.1551107536800; Mon, 25 Feb 2019 07:12:16 -0800 (PST) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id j14sm8164829pfn.77.2019.02.25.07.12.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 07:12:16 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r344518 - head/share/man/man9 From: Enji Cooper X-Mailer: iPhone Mail (16D57) In-Reply-To: <201902251503.x1PF3otL011409@repo.freebsd.org> Date: Mon, 25 Feb 2019 07:12:15 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <9F0A25DA-E0D2-4F96-91AF-4648367E3E5F@gmail.com> References: <201902251503.x1PF3otL011409@repo.freebsd.org> To: Mateusz Piotrowski <0mp@freebsd.org> X-Rspamd-Queue-Id: 915FE6A491 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.975,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 15:12:19 -0000 > On Feb 25, 2019, at 07:03, Mateusz Piotrowski <0mp@freebsd.org> wrote: >=20 > Author: 0mp (ports committer) > Date: Mon Feb 25 15:03:50 2019 > New Revision: 344518 > URL: https://svnweb.freebsd.org/changeset/base/344518 >=20 > Log: > Add missing types to the sysctl(9) manual page >=20 > Update the diff to include other missing sysctl types found in sysctl.h. >=20 > Some of these sysctls are already documented in other pages (e.g counter(= 9) > and ZONE(9)), but they should at least be mentioned here for completeness= . >=20 > This patch now documents all of the following: > - SYSCTL_BOOL/SYSCTL_ADD_BOOL > - SYSCTL_COUNTER_U64/SYSCTL_ADD_COUNTER_U64 > - SYSCTL_COUNTER_U64_ARRAY/SYSCTL_ADD_COUNTER_U64_ARRAY > - SYSCTL_SBINTIME_MSEC/SYSCTL_ADD_SBINTIME_MSEC > - SYSCTL_SBINTIME_USEC/SYSCTL_ADD_SBINTIME_USEC > - SYSCTL_UMA_CUR/SYSCTL_ADD_UMA_CUR > - SYSCTL_UMA_MAX/SYSCTL_ADD_UMA_MAX >=20 > Submitted by: mhorne063_gmail.com > Reviewed by: bcr, hselasky > Approved by: bcr (doc), hselasky (src) > Approved by: krion (mentor, implicit), mat (mentor, implicit) > Differential Revision: https://reviews.freebsd.org/D19272 >=20 > Modified: > head/share/man/man9/sysctl.9 ... > @@ -52,10 +57,15 @@ > .Nm SYSCTL_ADD_UINT , > .Nm SYSCTL_ADD_ULONG , > .Nm SYSCTL_ADD_UQUAD , > +.Nm SYSCTL_ADD_UMA_CUR , > +.Nm SYSCTL_ADD_UMA_MAX , Same as my comment below. > .Nm SYSCTL_CHILDREN , > .Nm SYSCTL_STATIC_CHILDREN , > .Nm SYSCTL_NODE_CHILDREN , > .Nm SYSCTL_PARENT , > +.Nm SYSCTL_BOOL , > +.Nm SYSCTL_COUNTER_U64 , > +.Nm SYSCTL_COUNTER_U64_ARRAY , > .Nm SYSCTL_INT , > .Nm SYSCTL_INT_WITH_LABEL , > .Nm SYSCTL_LONG , > @@ -69,6 +79,8 @@ > .Nm SYSCTL_S16 , > .Nm SYSCTL_S32 , > .Nm SYSCTL_S64 , > +.Nm SYSCTL_SBINTIME_MSEC , > +.Nm SYSCTL_SBINTIME_USEC , > .Nm SYSCTL_STRING , > .Nm SYSCTL_STRUCT , > .Nm SYSCTL_U8 , > @@ -77,13 +89,47 @@ > .Nm SYSCTL_U64 , > .Nm SYSCTL_UINT , > .Nm SYSCTL_ULONG , > -.Nm SYSCTL_UQUAD > +.Nm SYSCTL_UQUAD , > +.Nm SYSCTL_UMA_CUR , > +.Nm SYSCTL_UMA_MAX Quick nit: UMA sorts before UQUAD. Also, these APIs deserve manpage links via MLINKS. Cheers! -Enji=