From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:45:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3969516A4CE; Mon, 18 Oct 2004 17:45:13 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12A7443D2F; Mon, 18 Oct 2004 17:45:13 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IHjCD4006293; Mon, 18 Oct 2004 10:45:12 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IHjB5w006292; Mon, 18 Oct 2004 10:45:11 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 10:45:11 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20041018174511.GA6079@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018173516.GB89681@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:45:13 -0000 On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > obrien 2004-10-18 17:19:36 UTC > > FreeBSD src repository > > Modified files: > > lib/libc/i386/net htonl.S ntohl.S > > Log: > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > > Revision Changes Path > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > : ENTRY(__htonl) > : movl 4(%esp),%eax > : +#ifdef I386_CPU > : xchgb %al,%ah > : roll $16,%eax > : xchgb %al,%ah > : +#else > : + bswap %eax > : +#endif > : ret > > Ahem, but this makes this code unsuitable for i386. Yes. You missed the discussion in freebsd-current on this? For 6-CURRENT and RELENG_5 running on a real I386 is not supported. > I386_CPU > is only defined if kernel config file has "cpu I386_CPU", and > this has little relation to libc if at all. I know. Give me some other symbol then we can publish that one should add to /etc/make.conf CFLAGS to try to build a userland for an I386. "I386_CPU" looks as good a spelling as any and I didn't see any need to spell it differently than in the kernel. -- -- David (obrien@FreeBSD.org)