Date: Wed, 1 Apr 2015 16:29:10 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Bartek Rutkowski <robak@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r382919 - in head/games/freedoko: . files Message-ID: <20150401162910.GC85612@FreeBSD.org> In-Reply-To: <201504011607.t31G7IW8057260@svn.freebsd.org> References: <201504011607.t31G7IW8057260@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 01, 2015 at 04:07:18PM +0000, Bartek Rutkowski wrote: > New Revision: 382919 > URL: https://svnweb.freebsd.org/changeset/ports/382919 > > [...] > do-install: > - ${INSTALL_PROGRAM} ${WRKSRC}/FreeDoko ${STAGEDIR}${PREFIX}/bin > + (cd ${WRKSRC} && ${INSTALL_PROGRAM} FreeDoko \ > + ${STAGEDIR}${PREFIX}/bin) And here I come again: why was this change needed? New version is bogus: it's not $cwd-agnostic, it's split into two commands and thus requires a "context" to follow; it functionally changes *nothing* and thus is clearly a gratuitous change. How many times do I have to explain this? :( > - cd ${WRKSRC}/../doc/manual && ${FIND} . | \ > - ${CPIO} --quiet -pdum ${STAGEDIR}${DOCSDIR} > - @${RMDIR} ${STAGEDIR}${DOCSDIR}/de/pictures > + @(cd ${WRKSRC}/../doc/manual && ${COPYTREE_SHARE} . \ > + ${STAGEDIR}${DOCSDIR}) We do not encourage muting installation commands. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150401162910.GC85612>