From owner-freebsd-libh Sun Jun 2 16:14:25 2002 Delivered-To: freebsd-libh@freebsd.org Received: from tomts14-srv.bellnexxia.net (tomts14.bellnexxia.net [209.226.175.35]) by hub.freebsd.org (Postfix) with ESMTP id 54DA137B400 for ; Sun, 2 Jun 2002 16:14:19 -0700 (PDT) Received: from shall.anarcat.ath.cx ([65.94.145.70]) by tomts14-srv.bellnexxia.net (InterMail vM.5.01.04.19 201-253-122-122-119-20020516) with ESMTP id <20020602231418.PJJA10788.tomts14-srv.bellnexxia.net@shall.anarcat.ath.cx>; Sun, 2 Jun 2002 19:14:18 -0400 Received: from lenny.anarcat.ath.cx (lenny.anarcat.ath.cx [192.168.0.4]) by shall.anarcat.ath.cx (Postfix) with SMTP id F3F2F5; Sun, 2 Jun 2002 19:17:58 -0400 (EDT) Received: by lenny.anarcat.ath.cx (sSMTP sendmail emulation); Sun, 2 Jun 2002 19:12:37 -0400 Date: Sun, 2 Jun 2002 19:12:37 -0400 From: The Anarcat To: Max Okumoto Cc: The Anarcat , libh@FreeBSD.ORG Subject: Re: cvs commit: libh/include/hui HuiTVObjects.hh libh/lib/hui HuiTVision_ButtonsGroupWidget.cc HuiTVision_CheckBoxesWidget.cc HuiTVision_InputLineWidget.cc HuiTVision_LabelWidget.cc HuiTVision_ListBoxWidget.cc HuiTVision_ProgressIndicatorWidget.cc HuiTVision_RadioMenuWidget.cc Message-ID: <20020602231237.GB288@lenny.anarcat.ath.cx> References: <20020601074915.C9BFB17407@usw4.freebsd.org> <20020602004111.GC357@lenny.anarcat.ath.cx> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U+BazGySraz5kW0T" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.99i Sender: owner-freebsd-libh@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --U+BazGySraz5kW0T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun Jun 02, 2002 at 02:15:31PM -0700, Max Okumoto wrote: >=20 > I am trying to find bugs in the widget layout code. The only > time these functions are called is from the constructors. > No other objects call minSize() or maxSize(), nor can you call > them from tcl. These kind of informations are precious to the project, and should be recorded in the CVS history. > In all cases the results are directly feed into resize() in the > constructor. But in most cases, the widget constructor already > sizes the object to the correct size... so its redundent to > resize it again. The constructors that require resize need to be > fixed. >=20 > FooWidget { > /** Constructor. */ > FooWidget() { resize(minSize()); } > }; But why does this *require* removing the whole minSize() functions? Couldn't these functions be used at some point? A. > The Anarcat writes: > > On Sat Jun 01, 2002 at 02:49:15AM -0500, Max Okumoto wrote: > > > > > > Removed minSize() from all the HuiTVision objects. > >=20 > > Why is this necessary? > >=20 > > A. --=20 Imagination is more important than knowledge - Albert Einstein --U+BazGySraz5kW0T Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE8+qZlttcWHAnWiGcRAvM8AJ4lpCFwcnguWUZljUjVjf5LvzFiLwCeKjwn naBcb3692tX74NyPdgt7qck= =gzp+ -----END PGP SIGNATURE----- --U+BazGySraz5kW0T-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-libh" in the body of the message