From owner-freebsd-ipfw@freebsd.org Tue Feb 28 17:54:25 2017 Return-Path: Delivered-To: freebsd-ipfw@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DC4CCF14D8 for ; Tue, 28 Feb 2017 17:54:25 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EFC4E809; Tue, 28 Feb 2017 17:54:24 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (220-253-188-71.dyn.iinet.net.au [220.253.188.71]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id v1SHsIj5015108 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 28 Feb 2017 09:54:21 -0800 (PST) (envelope-from julian@freebsd.org) Subject: Re: dummynet loses ports mask bits To: Luigi Rizzo References: Cc: "freebsd-ipfw@freebsd.org" , Luigi Rizzo From: Julian Elischer Message-ID: <87c6774f-1a6a-c547-a027-17baa6d3d9f9@freebsd.org> Date: Wed, 1 Mar 2017 01:54:13 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 17:54:25 -0000 On 1/3/17 1:46 am, Luigi Rizzo wrote: > On Tue, Feb 28, 2017 at 9:27 AM, Julian Elischer wrote: >> In the following example it appears that the mask bits for the port number >> are lost. >> before I raise a bug.. is there anyone who can see that I am doing anything >> wrong? >> >> I'm not sure what the q131053 stuff is about either, but.. > q131053 is the internal name for the queue associated with the pipe > (pipe# + 0x10000). > I am not sure if the mask supports ip/port notation (dst-ip covers > only the address part). > Of course the real bug is that the parser should be more strict and complain > about extra/ignored fields. But the ipfw parser is full of these things. > > cheers > luigi my error is I should have used dst-port 0x000f not /0x000f seems to be working now > >> ------------------------------------------ >> FreeBSD fb10-cc03.kumo.com 10.3-RELEASE-p16 : Wed Feb 22 14:40:53 UTC 2017 >> amd64 >> >> fb10-cc03# ipfw pipe 11 config mask dst-ip 0x000000ff/0x0fff bw 200Kbit/s >> >> fb10-cc03# ipfw pipe show >> 00011: 200.000 Kbit/s 0 ms burst 0 >> q131083 50 sl. 0 flows (1 buckets) sched 65547 weight 0 lmax 0 pri 0 >> droptail >> sched 65547 type FIFO flags 0x1 64 buckets 0 active >> mask: 0x00 0x00000000/0x0000 -> 0x000000ff/0x0000 >> > >