From owner-cvs-src@FreeBSD.ORG Mon Feb 7 18:39:08 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C7F616A4CE; Mon, 7 Feb 2005 18:39:08 +0000 (GMT) Received: from ylpvm29.prodigy.net (ylpvm29-ext.prodigy.net [207.115.57.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1827543D48; Mon, 7 Feb 2005 18:39:08 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222])j17Icrh2009574; Mon, 7 Feb 2005 13:38:53 -0500 Message-ID: <4207B5C9.4030505@root.org> Date: Mon, 07 Feb 2005 10:39:05 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041205) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200502061655.j16GtqDK033151@repoman.freebsd.org> <200502071015.39224.jhb@FreeBSD.org> In-Reply-To: <200502071015.39224.jhb@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Ian Dowse Subject: Re: cvs commit: src/sys/dev/random probe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2005 18:39:08 -0000 John Baldwin wrote: > On Sunday 06 February 2005 11:55 am, Ian Dowse wrote: > >>iedowse 2005-02-06 16:55:52 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/random probe.c >> Log: >> Check that we have at least a 586-class CPU before calling do_cpuid(). >> This fixes booting on a number of 486 processors. > > > This is wrong. Some 486's do have cpuid, notable the dx4's (I used to have > one.) The correct test is to see if you can flip a bit in %eflags (can't > remember which one). If that flag stays at zero then you don't have cpuid, > if the bit follows the value written to it then you do have cpuid. That matters little since the cpuid result is then used to check for a VIA part introduced in 2003. -- Nate