From owner-freebsd-current@FreeBSD.ORG Tue Nov 25 09:46:10 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7475A1065670 for ; Tue, 25 Nov 2008 09:46:10 +0000 (UTC) (envelope-from rink@rink.nu) Received: from mx1.rink.nu (gloom.rink.nu [213.34.49.2]) by mx1.freebsd.org (Postfix) with ESMTP id 359C68FC12 for ; Tue, 25 Nov 2008 09:46:10 +0000 (UTC) (envelope-from rink@rink.nu) Received: from localhost (localhost [127.0.0.1]) by mx1.rink.nu (Postfix) with ESMTP id 179A06D439; Tue, 25 Nov 2008 10:46:39 +0100 (CET) X-Virus-Scanned: amavisd-new at rink.nu Received: from mx1.rink.nu ([213.34.49.2]) by localhost (gloom.rink.nu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Aw+vU2hNjCn3; Tue, 25 Nov 2008 10:46:35 +0100 (CET) Received: by mx1.rink.nu (Postfix, from userid 1000) id EF6A06D42B; Tue, 25 Nov 2008 10:46:35 +0100 (CET) Date: Tue, 25 Nov 2008 10:46:35 +0100 From: Rink Springer To: Luigi Rizzo Message-ID: <20081125094635.GA64854@rink.nu> References: <20081125094125.GA18669@onelab2.iet.unipi.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081125094125.GA18669@onelab2.iet.unipi.it> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: current@freebsd.org Subject: Re: small newfs_msdos addition X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 09:46:10 -0000 Hi Luigi, On Tue, Nov 25, 2008 at 10:41:25AM +0100, Luigi Rizzo wrote: > If there are no objections I'd like to commit the small patch below > to newfs_msdos.c -- all it does is create a fake geometry if > it cannot get the media size, which is handy when you want to > create a filesystem image on a regular file. Hmm, what about adding this as a seperate option, or perhaps printing a message that it made a wild guess? When I create a md(4), I may have accidently forgotten to specify the geometry and I would like to be reminded that it made something up, rather than just continueing and leaving me with an unusuable image. Just my EUR 0.02. Regards, -- Rink P.W. Springer - http://rink.nu "Anyway boys, this is America. Just because you get more votes doesn't mean you win." - Fox Mulder