From owner-svn-src-head@FreeBSD.ORG Tue Nov 11 01:32:13 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA356106567C; Tue, 11 Nov 2008 01:32:13 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id C7B538FC14; Tue, 11 Nov 2008 01:32:13 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTP id 41E7A46B0C; Mon, 10 Nov 2008 20:32:13 -0500 (EST) Date: Tue, 11 Nov 2008 01:32:13 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Ed Schouten In-Reply-To: <200811091045.mA9AjDDq037323@svn.freebsd.org> Message-ID: References: <200811091045.mA9AjDDq037323@svn.freebsd.org> User-Agent: Alpine 1.10 (BSF 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184789 - in head: lib/libc/amd64/sys lib/libc/arm/sys lib/libc/i386/sys lib/libc/ia64/sys lib/libc/mips/sys lib/libc/powerpc/sys lib/libc/sparc64/sys sys/amd64/linux32 sys/compat/freeb... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2008 01:32:14 -0000 On Sun, 9 Nov 2008, Ed Schouten wrote: > Modified: head/sys/sys/priv.h > ============================================================================== > --- head/sys/sys/priv.h Sun Nov 9 09:24:01 2008 (r184788) > +++ head/sys/sys/priv.h Sun Nov 9 10:45:13 2008 (r184789) > @@ -84,7 +84,6 @@ > #define PRIV_CLOCK_SETTIME 17 /* Can call clock_settime. */ > #define PRIV_SETTIMEOFDAY 18 /* Can call settimeofday. */ > #define PRIV_SETHOSTID 19 /* Can call sethostid. */ > -#define PRIV_SETDOMAINNAME 20 /* Can call setdomainname. */ Because kernel modules and applications may have been compiled with a specific understanding of what privilege '20' is, I think it would be a good idea to leave a placeholder name here to discourage reallocation of the same privilege number to a new privilege. For example: #define _PRIV_SETDOMAINNAME 20 /* Removed. */ This would help prevent future accidents, and we might want to add a note along those lines to the comments in priv.h. Robert N M Watson Computer Laboratory University of Cambridge