From owner-freebsd-ports@FreeBSD.ORG Tue Feb 8 19:12:13 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E2471065670 for ; Tue, 8 Feb 2011 19:12:13 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 607D28FC17 for ; Tue, 8 Feb 2011 19:12:13 +0000 (UTC) Received: by iwn39 with SMTP id 39so6139762iwn.13 for ; Tue, 08 Feb 2011 11:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=3Hc2Luh31INGBmfGnHh3x4x8guiBMkEbxzZJ99PXoBY=; b=qp531A1u4nNKwH/CK2I8ZsZkKnHnZo8qfdvgf/oLveYfYccIj1qVBNdOyH20KyHBiy FSI5T+2H6FMYrN16cXmBrG4w8e2P+oqZimZtOhx79J8cbvZqiVhrX1onZI9i5E63c6CW BolxouQiWX93qkPz7yRPN6NWslwoO/oqrhUZA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=BYjlOQ8GT2PPnEmrsQXdvIE3km3yLmI7jN+wR4L2ESPAmltGk1/3rjVCVv2xaIOkqg 2dSh6n91orzTLdOk9mhd/NrTixOb+s1xrkdcyNA5e+qzt8nRyBHupBBGR8JsBDHJtvd9 +1K/2E5dJ1/pJzoJE0XotL7miu3Mqg9AgjJ/s= Received: by 10.231.157.211 with SMTP id c19mr11715767ibx.172.1297192332465; Tue, 08 Feb 2011 11:12:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.183.134 with HTTP; Tue, 8 Feb 2011 11:11:52 -0800 (PST) In-Reply-To: References: From: Eitan Adler Date: Tue, 8 Feb 2011 14:11:52 -0500 Message-ID: To: arrowdodger <6yearold@gmail.com> Content-Type: text/plain; charset=UTF-8 Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2011 19:12:13 -0000 On Tue, Feb 8, 2011 at 6:40 AM, arrowdodger <6yearold@gmail.com> wrote: > Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is > my first attempt in port creation, so i want someone to review it. Hi, Congrats on your first attempt! Here are a few issues with the port. Please don't take them personally. 1) install port-mgmt/portlint and run it on your port (portlint -CN) it will point out a lot of things 2) The preferred format for new ports is a shar - not a .tar.gz file 3) It is not newline terminated 4) the .egg-info files should not be included in the pkg-plist 5) replace @dirrm lib/nautilus with @dirrmtry lib/nautilus because your port does not directly create this directories 6) And what i've been told is that i should use EXTRA_PATCHES, insteand of invoking patch. --> yes. Please use a patch file unless it something that has to be run on a significant number of files. reinplace makes it harder to find out what is being patched. You may want to use 'make makepatch' to generate them. -- Eitan Adler