From nobody Thu Aug 6 15:01:44 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hG9V06wQLz6nBRQ for ; Thu, 06 Aug 2026 15:01:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hG9V04WXjz3Dxm for ; Thu, 06 Aug 2026 15:01:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786028504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gMSVOhNy0s5xgfFiTGDW9Xj2sfBQcGAPafJhWiLmyqw=; b=vdxViRp5ooDn+Oji2wlq0QvOwOACG39W7G3ocKOJyrwoWnm7atuC09kyVEGoZM2Agui0R8 Zc3gMuL+iIqOYP9OyCrtnrSGuMLp1m2rF7ebPXY3y/I18WJq0Fo9rM+hCwjdm4oNM6N0fg YbFUlaipqESCznSiC6gyT4+2hAX5DjqwFcd8e+GklMW/toN7PfEUxLSlqaHcaLKeW9pvIR iXzT4M9k43arRywn0M3XAznUonKV+BECCeubx2b2zoGEVaVKL2UPNtrZYxtT4tLNxMGB8F BMBkwXcxOKelZNPH9hUm6qDApPMKUgDU1pQUBWpF90jPYGgcFOXFr920hKw5pg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786028504; a=rsa-sha256; cv=none; b=UT4p6QcV+lwz8R158vJg4PuQNfpji+oiaHTzZ+U+/0BD/6RV7MmQlG5QChg2bf7Tb5dd7S rlnsc5+gi/7Lk68OGsz2BsiVfWTDJ+Pd6n3lnafDuR4O89BGiWoFYsnh0N0hTAcbQnCSZ5 YIutKDb6MnDoce6a56zrPPN2Ths9VL9sqi5jxgZbFO0yIVmu6KEy7LL6DQnuTnFifs/bbn ZgrH3JH8tHQdwBVbLKzamqF6siRJ+wCkZHwbFJnwAtu7R8F0oPTatx4XL2iwl7PGZ+tblK t03wwxOt1zKoBN7yEwovP2yh6xjDeNgCwIH6FHYywWN2pRlaqJkvJd9CjqcZWA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786028504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gMSVOhNy0s5xgfFiTGDW9Xj2sfBQcGAPafJhWiLmyqw=; b=TPrwDSV1Z1nuXpMD9GSOBg/1ARXoqYz05ct549AVm+QnDOGeLdQNrtVrq8bbB/Eq7GKPoz 02lI3jIMP2CO/Ke8dCNt38rht6+OF30Z88unvYPupkUqHE09NdiyyjzLDxGAn+47pv9boz PkK+UVoKjSPdE6q+4GwwdAz9NxU8AbXpHdA+9suq5pg2T1b9ieCNC1JKS/RxbCl/yhRwTm aa8ijSGJ6jShH+f4hy8tRQg5yT/xnWx5P5IrMYenxs0A1cg/GGa0/A6z4uk5d/Uj2O1uQ/ Nmtr0LyPHmCRmeBgcJiDtHurX+uj6BKNSonZYXzwmFYIFWx/yY0inPHlIR6D5A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hG9V03Qc0z9QW for ; Thu, 06 Aug 2026 15:01:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 455ff by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 06 Aug 2026 15:01:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: c68c7059a586 - stable/15 - ipsec: Fix a lock leak in ipsec_chkreplay() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c68c7059a586f05e725255234fac37ba1c89668d Auto-Submitted: auto-generated Date: Thu, 06 Aug 2026 15:01:44 +0000 Message-Id: <6a74a1d8.455ff.e4b1605@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c68c7059a586f05e725255234fac37ba1c89668d commit c68c7059a586f05e725255234fac37ba1c89668d Author: Mark Johnston AuthorDate: 2026-07-29 13:19:08 +0000 Commit: Mark Johnston CommitDate: 2026-08-06 13:24:43 +0000 ipsec: Fix a lock leak in ipsec_chkreplay() Reported by: Chris Jarrett-Davies of the OpenAI Codex Security Team Reviewed by: pouria, kp Fixes: 0361f165f219 ("ipsec: replace SECASVAR mtx by rmlock") MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58521 (cherry picked from commit b6823a973737f06ea6cf0ea5a3083383af2ba5a4) --- sys/netipsec/ipsec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netipsec/ipsec.c b/sys/netipsec/ipsec.c index 92d0201b398a..12d1b7945e64 100644 --- a/sys/netipsec/ipsec.c +++ b/sys/netipsec/ipsec.c @@ -1353,8 +1353,10 @@ ipsec_chkreplay(uint32_t seq, uint32_t *seqhigh, struct secasvar *sav) * subspace. */ if (tl < window - 1 && seq >= bl) { - if (th == 0) + if (th == 0) { + SECREPLAY_UNLOCK(replay); return (0); + } *seqhigh = th - 1; seqh = th - 1; if (check_window(replay, seq)) {