Date: Wed, 14 Sep 2016 18:26:50 -0500 From: John Marino <freebsd.contact@marino.st> To: Steve Wills <swills@FreeBSD.org>, marino@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>, Adam Weinberger <adamw@anoxia.adamw.org>, Antoine Brodin <antoine@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r422160 - in head: chinese/fortune french/fortune-mod-zarathoustra misc/fortune-mod-bible misc/fortune-mod-bofh misc/fortune-mod-culmea-culmilor misc/fortune-mod-epictetus misc/fortune-... Message-ID: <fbff034a-4913-baa1-b4f2-20517c2567c8@marino.st> In-Reply-To: <fd84c676-12f3-3187-c129-fe7a8381b8ff@FreeBSD.org> References: <201609141950.u8EJolO7085386@repo.freebsd.org> <857FD0DF-6ADA-48F5-B02B-81BCA7135E2C@adamw.org> <03e06c33-6185-334f-bf04-71321aaf2cb7@FreeBSD.org> <9ffe58d7-66b0-b357-1777-6e4d3d4f5297@marino.st> <fea8b56c-6aa1-2ec9-f66f-e17a8a912e0a@FreeBSD.org> <9d118285-dd65-0b88-59cd-c8130d4d4f6f@marino.st> <087264b0-36ab-e844-f2f9-8389566dd654@FreeBSD.org> <55840821-5f88-54b6-4b99-eb8e09d0ae22@marino.st> <0aaad8b7-67f7-1b08-81be-7610d74d5e1c@FreeBSD.org> <00cb53dd-c51f-ce2f-378d-9e77d49e830b@marino.st> <fd84c676-12f3-3187-c129-fe7a8381b8ff@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/14/2016 18:23, Steve Wills wrote: > Hi, > > On 09/14/2016 18:49, John Marino wrote: >> Only something that didn't review the commit would say that. It is >> cleaner and that's pretty much indisputable. > > Are you saying that fortune_strfile doesn't duplicate /usr/bin/strfile? > I'm saying look at the diff. I'm also saying that my solutions works in 100% of the cases the old/reverted form does not. The makefile is cleaner and more performant. The duplication of a tiny utility for build purposes is a red herring. to recap: 1) the fortune makefiles are a lot cleaner 2) it builds fortune ports in more (all) cases It's just superior. There's no technical basis for reverting it. --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fbff034a-4913-baa1-b4f2-20517c2567c8>