From owner-freebsd-current@FreeBSD.ORG Sun Jun 27 19:34:30 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE78416A4CE; Sun, 27 Jun 2004 19:34:29 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 985CD43D41; Sun, 27 Jun 2004 19:34:29 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 2D025ACAF8; Sun, 27 Jun 2004 21:33:44 +0200 (CEST) Date: Sun, 27 Jun 2004 21:33:44 +0200 From: Pawel Jakub Dawidek To: "Bjoern A. Zeeb" Message-ID: <20040627193344.GO12007@darkness.comp.waw.pl> References: <20040627065932.GH12007@darkness.comp.waw.pl> <20040627101951.GJ12007@darkness.comp.waw.pl> <20040627160959.GL12007@darkness.comp.waw.pl> <20040627174040.GM12007@darkness.comp.waw.pl> <20040627180847.GN12007@darkness.comp.waw.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pd63dsUMqOR/a9gp" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: Robert Watson cc: Julian Elischer cc: "Bjoern A. Zeeb" cc: FreeBSD current users Subject: Re: jail getfsstat patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jun 2004 19:34:30 -0000 --pd63dsUMqOR/a9gp Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 27, 2004 at 06:32:49PM +0000, Bjoern A. Zeeb wrote: +> > It starts from: +> > +> > error =3D suser(td); +> > if (error) +> > return (error); +> > +> > So I don't think it is needed here, but we can put this there just in +> > case of future changes. +>=20 +> for that and perhaps just for consistency with freebsd4_fhstatfs ? This is not intended in freebsd4_fhstatfs(). It is there only because cvtstatfs() is used also by freebsd4_statfs(), freebsd4_fstatfs() and freebsd4_getfsstat(). Anyway. I updated the patch. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --pd63dsUMqOR/a9gp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA3yEYForvXbEpPzQRAh90AJoDvHswWRaKhMCC0AL/Ht8gcMLPDACfbUUK AXmlXSWNirDK/THNgmkdj6s= =5U8I -----END PGP SIGNATURE----- --pd63dsUMqOR/a9gp--