From owner-svn-src-head@freebsd.org Sat Dec 5 17:06:34 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 762B3A42DC1; Sat, 5 Dec 2015 17:06:34 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1F3D01F23; Sat, 5 Dec 2015 17:06:34 +0000 (UTC) (envelope-from kubito@gmail.com) Received: by wmec201 with SMTP id c201so113656688wme.0; Sat, 05 Dec 2015 09:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=L3va/+p2SxTqYrJ9jyhbSxV4t0Sqq+WaKcUQePrWEvk=; b=e9z8uh6XNlPtHZr1NyOdxcBNoOnXZrXSZcMvG5/3ojv1/a20SsnsuJnA15vapjkPmf M5u+KA4OOqBoiwzkf7YLOXZpbptv2N6zi2ZUEXQ+ZmbLIdvMRY8wnIQ+r1TrKMdNuVyL FmDjoDMwmFtVXe+GKG/4amfH7VhWflUp/kjk77ugcHfOHfqgTyjg97oFLDdy89Kg+twg /jGrBYfG9fKLBBp1u962M56JPdrGJ/ZATdyukaLztP0cAqxDWZYmgmFUniDg0Hk7tB7Y 6Yk5l+PzSggZDVyMYhpu55b5SmcsEUrNtnft91A4SBgoUReIOqu9qYR+TRySVjEH1iMk FxdA== X-Received: by 10.194.87.39 with SMTP id u7mr23783762wjz.11.1449335191585; Sat, 05 Dec 2015 09:06:31 -0800 (PST) Received: from orwell.gmail.com (dhcp-077-248-147-050.chello.nl. [77.248.147.50]) by smtp.gmail.com with ESMTPSA id kc9sm17163832wjc.34.2015.12.05.09.06.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Dec 2015 09:06:30 -0800 (PST) Sender: Raphael Kubo da Costa From: Raphael Kubo da Costa To: Eric van Gyzen Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289315 - in head: include lib/libc/resolv share/man/man5 References: <201510141426.t9EEQiWX079418__45653.4197823659$1444832818$gmane$org@repo.freebsd.org> Date: Sat, 05 Dec 2015 18:06:24 +0100 In-Reply-To: <201510141426.t9EEQiWX079418__45653.4197823659$1444832818$gmane$org@repo.freebsd.org> (Eric van Gyzen's message of "Wed, 14 Oct 2015 14:26:44 +0000 (UTC)") Message-ID: <86r3j06d0v.fsf@FreeBSD.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2015 17:06:34 -0000 Eric van Gyzen writes: > Author: vangyzen > Date: Wed Oct 14 14:26:44 2015 > New Revision: 289315 > URL: https://svnweb.freebsd.org/changeset/base/289315 > > Log: > resolver: automatically reload /etc/resolv.conf > > [...] > > Modified: head/include/resolv.h > ============================================================================== > --- head/include/resolv.h Wed Oct 14 12:46:05 2015 (r289314) > +++ head/include/resolv.h Wed Oct 14 14:26:44 2015 (r289315) > > [...] > > @@ -188,6 +189,8 @@ struct __res_state { > } _ext; > } _u; > u_char *_rnd; /*%< PRIVATE: random state */ > + struct timespec conf_mtim; /*%< mod time of loaded resolv.conf */ > + time_t conf_stat; /*%< time of last stat(resolv.conf) */ > }; With this change, including the headers listed in resolver(3), sys/types.h, netinet/in.h, arpa/nameser.h and resolv.h is not enough, as resolv.h now depends on sys/time.h. This has broken at least one port, net-mgmt/sx. It includes those 4 headers to find if the resolver library is in libc. The test program fails like this: In file included from conftest.c:31: /usr/include/resolv.h:192:18: error: field has incomplete type 'struct timespec' struct timespec conf_mtim; /*%< mod time of loaded resolv.conf */ ^ /usr/include/resolv.h:192:9: note: forward declaration of 'struct timespec' struct timespec conf_mtim; /*%< mod time of loaded resolv.conf */ ^