From nobody Sat Mar  1 02:34:35 2025
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z4TgT5vmkz5hjnn;
	Sat, 01 Mar 2025 02:34:45 +0000 (UTC)
	(envelope-from kevlo@freebsd.org)
Received: from mail.kevlo.org (ns.kevlo.org [220.134.220.36])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4Z4TgS3KDvz3Zs7;
	Sat, 01 Mar 2025 02:34:44 +0000 (UTC)
	(envelope-from kevlo@freebsd.org)
Authentication-Results: mx1.freebsd.org;
	none
Received: from localhost (ns.kevlo.org [local])
	by ns.kevlo.org (OpenSMTPD) with ESMTPA id 498fd117;
	Sat, 1 Mar 2025 10:34:35 +0800 (CST)
Date: Sat, 1 Mar 2025 10:34:35 +0800
From: Kevin Lo <kevlo@freebsd.org>
To: Kevin Bowling <kevin.bowling@kev009.com>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
	dev-commits-src-main@freebsd.org
Subject: Re: git: 5c7087c349fc - main - ixgbe: Fix a logic error in
 ixgbe_read_mailbox_vf() Reviewed by: kbowling Differential Revision:
 https://reviews.freebsd.org/D49156
Message-ID: <Z8JyOyxlvpVsSW0X@ns.kevlo.org>
References: <202502280813.51S8DQiZ037985@gitrepo.freebsd.org>
 <CAK7dMtCym4aQ7RiFYZxJCh8SptNSE4_1nBKYJWeXaKLh5Owxiw@mail.gmail.com>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
X-BeenThere: dev-commits-src-all@freebsd.org
Sender: owner-dev-commits-src-all@FreeBSD.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7dMtCym4aQ7RiFYZxJCh8SptNSE4_1nBKYJWeXaKLh5Owxiw@mail.gmail.com>
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:3462, ipnet:220.134.0.0/16, country:TW]
X-Rspamd-Queue-Id: 4Z4TgS3KDvz3Zs7
X-Spamd-Bar: ----

On Fri, Feb 28, 2025 at 01:54:08AM -0700, Kevin Bowling wrote:
>
> MFC?

Done.  Thanks for reminding me.

> On Fri, Feb 28, 2025 at 1:13???AM Kevin Lo <kevlo@freebsd.org> wrote:
> >
> > The branch main has been updated by kevlo:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=5c7087c349fc1d826807aa1a11912c9e774e3321
> >
> > commit 5c7087c349fc1d826807aa1a11912c9e774e3321
> > Author:     Kevin Lo <kevlo@FreeBSD.org>
> > AuthorDate: 2025-02-28 08:12:00 +0000
> > Commit:     Kevin Lo <kevlo@FreeBSD.org>
> > CommitDate: 2025-02-28 08:12:00 +0000
> >
> >     ixgbe: Fix a logic error in ixgbe_read_mailbox_vf()
> >     Reviewed by:    kbowling
> >     Differential Revision:  https://reviews.freebsd.org/D49156
> > ---
> >  sys/dev/ixgbe/ixgbe_mbx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sys/dev/ixgbe/ixgbe_mbx.c b/sys/dev/ixgbe/ixgbe_mbx.c
> > index 5f1f64e02b82..0b866e7a39af 100644
> > --- a/sys/dev/ixgbe/ixgbe_mbx.c
> > +++ b/sys/dev/ixgbe/ixgbe_mbx.c
> > @@ -297,7 +297,7 @@ static u32 ixgbe_read_mailbox_vf(struct ixgbe_hw *hw)
> >         u32 vf_mailbox = IXGBE_READ_REG(hw, IXGBE_VFMAILBOX);
> >
> >         vf_mailbox |= hw->mbx.vf_mailbox;
> > -       hw->mbx.vf_mailbox |= vf_mailbox % IXGBE_VFMAILBOX_R2C_BITS;
> > +       hw->mbx.vf_mailbox |= vf_mailbox & IXGBE_VFMAILBOX_R2C_BITS;
> >
> >         return vf_mailbox;
> >  }