From nobody Sun Apr 28 12:37:48 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VS5bJ3FZzz5J9Yb; Sun, 28 Apr 2024 12:38:04 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VS5bG5FQ9z4d30; Sun, 28 Apr 2024 12:38:02 +0000 (UTC) (envelope-from mpp302@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=mpp302@gmail.com Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2db239711ebso8922031fa.1; Sun, 28 Apr 2024 05:38:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714307880; x=1714912680; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MkYB5BkpAd+CUHu3Ol2C/vZiMFQtnWUGP/w49DfCSBo=; b=PYjDwJEEYm+w97UEXS8t/8xNupZTq7ACwFY5eGIBi5io6Jwmt7Eg5aiCtj8XpvtoFG PExVPXFDzugd4o/rkSJnHlPNxPuPVwlc9NN1hdahXJz6/8qEZpdpXBfDGedOeL0lC+eC 4tQ1DG/GQH+nWmVt5Fc8EUToPe99llCg17003PCs0pMw5YINv/klX9L2Of+Go/mYE15T uoI1tKDNxqyy8PlvjtwFSsVbEwCJcl20e3x5xWnDpLNIv0EvbS2nuVf/aWqNW1D9C6mr A41KY8Ea/vo9FZRpeM8n/mIzdCAxyEg7GnrjbeP2gA73wsL0sTFu/sZi3rFWrlXPKsuI 5jEQ== X-Forwarded-Encrypted: i=1; AJvYcCUdOm8ocZN9wXCnJVa4JAshsRJH0hLRaXrb8EzUsP+1/GPcFoKaUQidZq27P7K8a4rzdTByvOFqImgpQFIulx2njyA9i0IL/LBf6mQNyMTG7f8kxVo8fJ6ktUL/qlac+ValDlnPRValU/atieOjd80ktg== X-Gm-Message-State: AOJu0YwGQXkAa4SqL1xKrqxMYvXex8aAG+rUonVEQn9nIrs3t7pJIqoR gnRWsXstMOVYJNSvOypJ9RlVL16jXGvF9KUrU/G6zO01WGgos/FSzKT/6RDE X-Google-Smtp-Source: AGHT+IHmprmZES6UCHpPJoXBQ6RMlJa4+NMsjkFUnffe0snTk/PzJ5Q2CbOr/p8dfnmFWZPPIBcGyQ== X-Received: by 2002:a2e:97d4:0:b0:2df:1e3e:27e8 with SMTP id m20-20020a2e97d4000000b002df1e3e27e8mr4320120ljj.0.1714307879831; Sun, 28 Apr 2024 05:37:59 -0700 (PDT) Received: from smtpclient.apple (ip5f5af551.dynamic.kabel-deutschland.de. [95.90.245.81]) by smtp.gmail.com with ESMTPSA id t16-20020a056402241000b005701eaa2023sm12260146eda.72.2024.04.28.05.37.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Apr 2024 05:37:59 -0700 (PDT) From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-Id: <026867C8-33DC-4555-8B6B-03E0E848510D@FreeBSD.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_9FB49A63-E48C-4927-8AF2-0542D31DC5BD" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: git: 5626f9e79090 - main - style.9: Document the existence of tools/build/checkstyle9.pl Date: Sun, 28 Apr 2024 14:37:48 +0200 In-Reply-To: Cc: src-committers , "" , "" To: Warner Losh References: <202404260938.43Q9cSwG055237@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spamd-Bar: - X-Spamd-Result: default: False [-1.28 / 15.00]; URI_COUNT_ODD(1.00)[9]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.88)[-0.878]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; ARC_NA(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; R_DKIM_NA(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.178:from]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.178:from] X-Rspamd-Queue-Id: 4VS5bG5FQ9z4d30 --Apple-Mail=_9FB49A63-E48C-4927-8AF2-0542D31DC5BD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hey Warner, Thanks for taking a look at the patch! > On 26. Apr 2024, at 15:30, Warner Losh wrote: > On Fri, Apr 26, 2024, 3:38=E2=80=AFAM Mateusz Piotrowski = <0mp@freebsd.org > wrote: >> The branch main has been updated by 0mp: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D5626f9e790901999def12040a60746b0= ceeb9b95 = [...] >>=20 >> style.9: Document the existence of tools/build/checkstyle9.pl = [...] >> share/man/man9/style.9 | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) [...] >> @@ -904,6 +904,10 @@ instead of the older >> .Fn CTASSERT . >> .Sh FILES >> .Bl -tag -width indent >> +.It Pa /usr/src/tools/build/checkstyle9.pl >> +A script to check for violations of >=20 >=20 > Egregious violations and there are some false positives still. checkstyle9 is already warning against those imperfections. I assumed = that there is no need to warn against those in the manual page as well. = I can add additional disclaimers if you think they are desired :) Best, Mateusz Piotrowski --Apple-Mail=_9FB49A63-E48C-4927-8AF2-0542D31DC5BD Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hey = Warner,

Thanks for taking a look at the patch!

On 26. Apr 2024, at 15:30, Warner Losh = <imp@bsdimp.com> wrote:
On Fri, Apr = 26, 2024, 3:38=E2=80=AFAM Mateusz Piotrowski <0mp@freebsd.org> = wrote:
The branch = main has been updated by 0mp:

URL: https://cgit.FreeBSD.org/src/commit/?id=3D5626f9e7909019= 99def12040a60746b0ceeb9b95
[...]

  =   style.9: = Document the existence of tools/build/checkstyle9.pl
[...]
 share/man/man9/style.9 | 6 +++++-
 1 file changed, 5 = insertions(+), 1 = deletion(-)
[...]
=
@@ -904,6 +904,10 @@ instead of = the older
 .Fn CTASSERT .
 .Sh FILES
 .Bl -tag = -width indent
+.It Pa /usr/src/tools/build/checkstyle9.pl
+A script to check for = violations of

Egregious violations and there are some false positives = still.

checkstyle9 is = already warning against those imperfections. I assumed that there is no = need to warn against those in the manual page as well. I can add = additional disclaimers if you think they are desired = :)

Best,
Mateusz = Piotrowski

= --Apple-Mail=_9FB49A63-E48C-4927-8AF2-0542D31DC5BD--