From owner-freebsd-acpi@FreeBSD.ORG  Wed Apr 15 16:30:17 2009
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 5F68C1065677;
	Wed, 15 Apr 2009 16:30:17 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Andriy Gapon <avg@freebsd.org>
Date: Wed, 15 Apr 2009 12:30:05 -0400
User-Agent: KMail/1.6.2
References: <49DB639A.4090504@icyb.net.ua>
	<200904151208.03822.jkim@FreeBSD.org>
	<49E60731.8050402@freebsd.org>
In-Reply-To: <49E60731.8050402@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200904151230.06288.jkim@FreeBSD.org>
Cc: freebsd-acpi@freebsd.org
Subject: Re: run resume code only for S1-S4 states
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2009 16:30:19 -0000

On Wednesday 15 April 2009 12:11 pm, Andriy Gapon wrote:
> on 15/04/2009 19:08 Jung-uk Kim said the following:
> > Actually, my patch was more complex, e.g., I added more code to
> > make sure power/sleep button events get ignored and cleared when
> > it is not in S0 state, etc.  Probably I needed to track the
> > current state because of it.  I think you may ignore it for now
> > if it is not needed anywhere else.
>
> Interesting. I think that I will go with the current patch (modulo
> break->goto changes), if my mentors approve. But I would like to
> see your patch :-)

I am not sure I still have it.  It wasn't finished (thus not 
committed) because it was a lot more complex than I originally 
thought.  We really have to consolidate ACPI state tracking in one 
variable outside of ACPI softc so that it can be atomically tracked 
without complex locking/unlocking layers of various locks, e.g., 
acpi_button from DSDT, fixed buttons from FADT, acpi, giant, etc. :-(

Jung-uk Kim