From owner-freebsd-current@freebsd.org Thu May 9 15:26:22 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CDF1D158453A for ; Thu, 9 May 2019 15:26:22 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 729F46D63C; Thu, 9 May 2019 15:26:22 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 04A05131D8; Thu, 9 May 2019 15:26:22 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f180.google.com with SMTP id n4so2391533ljg.4; Thu, 09 May 2019 08:26:21 -0700 (PDT) X-Gm-Message-State: APjAAAUAPz8WKSI/wnP1A3yN8Zp/5yC6AS9iMJJnxHVpL9wljdPeW2vz 23t9t6/mOwbivkXUyNVGKGHKxHgazO4K65+9HYs= X-Google-Smtp-Source: APXvYqziqv95+wqfqg/EHbtIdcuNCv2jOwCpx+zqfnrsilBglNgryitqW5PBVZ0nYbQa4ryWvWhxaDtZPxGHlHPtptk= X-Received: by 2002:a2e:8996:: with SMTP id c22mr2871178lji.81.1557415580670; Thu, 09 May 2019 08:26:20 -0700 (PDT) MIME-Version: 1.0 References: <58ad8292-a24b-b9ce-a1a2-3e159f42ed78@protected-networks.net> <5333dd8d-9e01-f748-1b79-5dd1b22bf15f@protected-networks.net> In-Reply-To: <5333dd8d-9e01-f748-1b79-5dd1b22bf15f@protected-networks.net> From: Kyle Evans Date: Thu, 9 May 2019 10:25:37 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: at SVN r347375, terminating/restarting openvpn on tap causes panic To: Michael Butler Cc: FreeBSD Current , glebius@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 729F46D63C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 15:26:23 -0000 On Thu, May 9, 2019 at 8:27 AM Michael Butler wrote: > > On 2019-05-09 09:07, Kyle Evans wrote: > > On Thu, May 9, 2019 at 7:24 AM Michael Butler > > wrote: > >> > >> Seems there's a lock or tuntap issue after recent changes. Restarting > >> openvpn (configured to use /dev/tap) yields a panic as follows: > >> > > > > Ah, I knew I was forgetting something. =( Give this a shot: > > https://people.freebsd.org/~kevans/etherdetach.diff > > Sorry - same result, > > (kgdb) bt > #0 doadump () at src/sys/amd64/include/pcpu.h:241 > #1 0xffffffff808393c8 in kern_reboot (howto=260) at > /usr/src/sys/kern/kern_shutdown.c:470 > #2 0xffffffff80839826 in vpanic (fmt=, ap= optimized out>) at /usr/src/sys/kern/kern_shutdown.c:896 > #3 0xffffffff80839663 in panic (fmt=) at > /usr/src/sys/kern/kern_shutdown.c:823 > #4 0xffffffff80c318a6 in trap_fatal (frame=0xfffffe0072b14510, eva=156) > at /usr/src/sys/amd64/amd64/trap.c:946 > #5 0xffffffff80c31c59 in trap_pfault (frame=0xfffffe0072b14510, > usermode=0) at src/sys/amd64/include/cpufunc.h:423 > #6 0xffffffff80c30fde in trap (frame=0xfffffe0072b14510) at > /usr/src/sys/amd64/amd64/trap.c:441 > #7 0xffffffff80c0d4b5 in calltrap () at > /usr/src/sys/amd64/amd64/exception.S:232 > #8 0xffffffff80a15377 in ip_output (m=, opt= optimized out>, ro=0x0, flags=0, imo=0xfffffe0072b14780, inp=0x0) at > /usr/src/sys/netinet/ip_output.c:362 > #9 0xffffffff809ffea4 in igmp_intr (m=) at > /usr/src/sys/netinet/igmp.c:3455 > #10 0xffffffff80975a0f in netisr_dispatch_src (proto=2, source= optimized out>, m=) at /usr/src/sys/net/netisr.c:1122 > #11 0xffffffff809fe07a in igmp_fasttimo () at > /usr/src/sys/netinet/igmp.c:496 > #12 0xffffffff808c5854 in pffasttimo (arg=) at > /usr/src/sys/kern/uipc_domain.c:521 > #13 0xffffffff80853df3 in softclock_call_cc (c=0xffffffff813f7f48, > cc=0xffffffff814c9ac0, direct=0) at /usr/src/sys/kern/kern_timeout.c:731 > #14 0xffffffff808542b9 in softclock (arg=0xffffffff814c9ac0) at > /usr/src/sys/kern/kern_timeout.c:869 > #15 0xffffffff807fd0c4 in ithread_loop (arg=) at > /usr/src/sys/kern/kern_intr.c:1129 > #16 0xffffffff807f9f33 in fork_exit (callout=0xffffffff807fcef0 > , arg=0xfffff800025f10a0, frame=0xfffffe0072b14ac0) at > /usr/src/sys/kern/kern_fork.c:1058 > #17 0xffffffff80c0e4ae in fork_trampoline () at > /usr/src/sys/amd64/amd64/exception.S:995 > #18 0x0000000000000000 in ?? () > Ah, I misread your backtrace (and forgot the proper tap detachment from my previous patch, so that's fixed/committed anyways). CC'ing Gleb for further triage as committer of r347375 that touched things in this path.