From nobody Thu Sep 21 22:25:09 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rs92F30Kdz4v58b for ; Thu, 21 Sep 2023 22:25:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rs92F1zzxz4HK6 for ; Thu, 21 Sep 2023 22:25:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695335109; a=rsa-sha256; cv=none; b=y3XnlRJ18lqaErhFK/mbO7ZmhZrE6+vLecbfZhqAWfft3VtXGDTrp5qw6BP5Jz8QI3cXnN 8sV5LXdZmcefvSTnkKFPMJdv3fYIEnlBWsT6ROe3zEidexlgwnpORFZ+A6YrSyEEdMDEVD tiaBYBF2nTnogBb9u2qvXwcwKWLltkJG7TcW5JT5UqGg+AK9htP9Xv/G4WTdnehvj1a0j3 dMOm4ijxo/580RV554aoStkRB2PyqjqZgmbitzouem6IYSsRmXLdFZroJpnALEuZIzHv7X SPOheVvAJwMyCIBBR5tPaqNoOT2GfA4YsNqS3XxoDdhXRu9c+5cykgccVg+T2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695335109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c6Tr9+jeGsJAEw9JBA9KmDxJdWxzYXkXgYWSoDsYXEA=; b=mxc613WtuAlk9SqNU3wNghgjWTkaWItKLo+OhpacdZN1Lnonm4wV39uyITCSy5pTfaWIXS qc5IuxTV8X9MM56hqA3n3IUZS9qdqtA9IfBoDxjOP1UC87TE4w8yoJ48qS3OgRgvCfW9iw j3Z2l+ALGTLCShsEPN+N7qJQXf7DCY8Rv3ObM8LcIg0IiDzpKhFKkg8Pq/lShOwe5FazM3 liNYzZP4PbBoM1LsuxMGTcBt2bJZZzPA/8R+0jzsHTsTx6y+87s26TohYShTlpLOU26VRk VVaNjnlDyhgjoNfYMnKUplfB9qHBW15M75X9VMZXFuHzHBmupl4m/XcZrw84dA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rs92F0t4xzx3H for ; Thu, 21 Sep 2023 22:25:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38LMP9mT077019 for ; Thu, 21 Sep 2023 22:25:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38LMP9uw077018 for fs@FreeBSD.org; Thu, 21 Sep 2023 22:25:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 273663] zfsd crashes in the presence of pools with removed TLVs Date: Thu, 21 Sep 2023 22:25:09 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: asomers@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable14? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273663 --- Comment #13 from commit-hook@FreeBSD.org --- A commit in branch releng/14.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Da015b9e690d87c45c73dd08840712f576= 894dbf9 commit a015b9e690d87c45c73dd08840712f576894dbf9 Author: Alan Somers AuthorDate: 2023-09-12 01:20:39 +0000 Commit: Alan Somers CommitDate: 2023-09-21 22:23:47 +0000 Fix zfsd with the device_removal pool feature. Previously zfsd would crash in the presence of a pool with a top-level-vdev that had previously been removed. The crash happened because the configuration nvlist of such a TLV contains an empty ZPOOL_CONFIG_CHILDREN array, which led to a pop_front from an empty list, which has undefined behavior. The crash only happened in stable/14 and later, probably do to differences in libcxx, but the change should be MFCed anyway. PR: 273663 Reported by: Marek Zarychta Sponsored by: Axcient Reviewed by: mav Differential Revision: https://reviews.freebsd.org/D41818 Approved by: gjb (re) (cherry picked from commit 0b294a386d34f6584848ed52407687df7ae59861) (cherry picked from commit a39aac5bb8e46b0d9cd77e85be8a65808f8a89ce) cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc | 37 +++++++++++++++++++++++++++= ++++ cddl/usr.sbin/zfsd/vdev_iterator.cc | 5 +---- 2 files changed, 38 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=