From owner-freebsd-arch@freebsd.org  Mon Feb 15 14:17:37 2016
Return-Path: <owner-freebsd-arch@freebsd.org>
Delivered-To: freebsd-arch@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB473AA995E
 for <freebsd-arch@mailman.ysv.freebsd.org>;
 Mon, 15 Feb 2016 14:17:37 +0000 (UTC)
 (envelope-from martin@lispworks.com)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id CB8111C1B
 for <freebsd-arch@freebsd.org>; Mon, 15 Feb 2016 14:17:37 +0000 (UTC)
 (envelope-from martin@lispworks.com)
Received: by mailman.ysv.freebsd.org (Postfix)
 id C6992AA995C; Mon, 15 Feb 2016 14:17:37 +0000 (UTC)
Delivered-To: arch@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6153AA995B;
 Mon, 15 Feb 2016 14:17:37 +0000 (UTC)
 (envelope-from martin@lispworks.com)
Received: from lwfs1-cam.cam.lispworks.com (mail.lispworks.com [46.17.166.21])
 by mx1.freebsd.org (Postfix) with ESMTP id 10E551C16;
 Mon, 15 Feb 2016 14:17:30 +0000 (UTC)
 (envelope-from martin@lispworks.com)
Received: from higson.cam.lispworks.com (higson.cam.lispworks.com
 [192.168.1.7])
 by lwfs1-cam.cam.lispworks.com (8.14.9/8.14.9) with ESMTP id u1FEHKDT031345;
 Mon, 15 Feb 2016 14:17:20 GMT (envelope-from martin@lispworks.com)
Received: from higson.cam.lispworks.com (localhost.localdomain [127.0.0.1]) by
 higson.cam.lispworks.com (8.14.4) id u1FEHKih003396;
 Mon, 15 Feb 2016 14:17:20 GMT
Received: (from martin@localhost)
 by higson.cam.lispworks.com (8.14.4/8.14.4/Submit) id u1FEHKwL003392;
 Mon, 15 Feb 2016 14:17:20 GMT
Date: Mon, 15 Feb 2016 14:17:20 GMT
Message-Id: <201602151417.u1FEHKwL003392@higson.cam.lispworks.com>
From: Martin Simmons <martin@lispworks.com>
To: Konstantin Belousov <kostikbel@gmail.com>
CC: vangyzen@FreeBSD.org, threads@FreeBSD.org, arch@FreeBSD.org
In-reply-to: <20160213143815.GB91220@kib.kiev.ua> (message from Konstantin
 Belousov on Sat, 13 Feb 2016 16:38:15 +0200)
Subject: Re: libthr shared locks
References: <20151223172528.GT3625@kib.kiev.ua> <56BE69B8.9020808@FreeBSD.org>
 <20160213143815.GB91220@kib.kiev.ua>
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Feb 2016 14:17:38 -0000

Is pthread_barrier_destroy making the wrong comparison?

+	if (barrier == THR_PSHARED_PTR) {

I think this should be *barrier.

Also, a general question: why not use some flag in the barrier (and other
objects) to indicate pshared, removing the need for __thr_pshared_offpage
except in init?

__Martin