From nobody Thu May 28 14:46:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gR8SR2gBKz6fqsW for ; Thu, 28 May 2026 14:46:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gR8SQ6MLtz3lJH for ; Thu, 28 May 2026 14:46:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779979574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TDm2qACsR9Li6caa/gKq9VZyf055xI0KHrGZZNGSbDQ=; b=T+rLMWY//bCEKiwL//kEpk2G+jHlHcujjPqHV/o4vuw28Lfx5PlroXVFOqzSBm409ex8P5 Z+LUT5cOm+2H8nfLE36IeOZt5vT6b2YqgvfWfclzwR0z/w26Q2Bw9gWUV6i/cqnmiTgTaq oaRjOccj+qqv+Drl1QAjfLGrBzNGPw1S/0WMTnzuWPyZi8Ce+6C/HitWUeAWkW17wydpN5 GLff/luz4gRKO7DQj6jawv2jNKO7vgFLpEPmQb8DsQ2mmyL/VxexCUSIqBrkxUiJ685u+H pESFDlAW59BXOc23ZMBDNbN+BVla4FLKxNLymJTZxMOSi/z1wBwTQWGsqYXSjQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779979574; a=rsa-sha256; cv=none; b=ar2jIkl2kX+W8r01BC7WWF0Be8QW17D1OBw6LgTVjSQ9gHy5g6DkkDEUuPR8SwpCxvNaxp 2i7OXPaQkENVt8p2kt97EpGQEEttusIVuvmvcWtAZwQfpzf+22yaxll04FH6b7b8bxfh3p 8BLxlGGRKsigsoOxpoLvIqwAN6B9H0aOviTRw7D45CBp44XnI8WEbguVJ7WvFtWPBbYBPI co6w2c3MTnDmKMouJFikczgjqGyFev0go5zV1hZQ+GIXibIozCujtIlOJQghlEaRPABiqI YrxlLYnm7vbMcH5dc0JbHgdwI1UWjSFN/qMbF8XGhQdm6f/+m1xwcgUDvcE7Iw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779979574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TDm2qACsR9Li6caa/gKq9VZyf055xI0KHrGZZNGSbDQ=; b=t6A7YFb5pHnXvdqt/BPzXDmE+S9JElaGoDa+GTP/+3eoPnsy9NZ4MYXYfGjk3tzZbd8oNl 5TRCNRvNIj/pbPU8eVzIvtx9iRggmyvvqvLVaDFsOt8m+dEGv5xUAZHdmquH8bTpFMnkGD K18RL1Ew6/+yoIeWyctufRp6k2gWcnyprhpr3H1c9gCuRDdCs2TZH34T3mYlZU/OxXZn0/ 1VXp3fz6MOAeGB1r22PcfPfFZ+jUocn3lihuSA2SewhitdgRpYdacVE2Oz963dWN3mEVUF UAfwDDua0FoVkhmJ0HCk4yRD3Gh4NKytNd0JQNtX6UG9U/nw5rqHp3jMaCrqUg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gR8SQ5y9nzrQ0 for ; Thu, 28 May 2026 14:46:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24195 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 28 May 2026 14:46:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 453de99b386d - main - virtual_oss(8): Fix buffer overflow in voss_compressor() call List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 453de99b386d40754a038cc4b804f4c7a3b04624 Auto-Submitted: auto-generated Date: Thu, 28 May 2026 14:46:09 +0000 Message-Id: <6a185531.24195.1452040e@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=453de99b386d40754a038cc4b804f4c7a3b04624 commit 453de99b386d40754a038cc4b804f4c7a3b04624 Author: Christos Margiolis AuthorDate: 2026-05-28 13:51:26 +0000 Commit: Christos Margiolis CommitDate: 2026-05-28 14:46:01 +0000 virtual_oss(8): Fix buffer overflow in voss_compressor() call This particular calls swaps the samples and maxchan arguments, which can cause a buffer overflow in p_ch_chain if maxchan exceeds its bounds (VMAX_CHAN). Reported by: Yuxiang Yang, Yizhou Zhao, Ao Wang, Xuewei Feng, Qi Li, and Ke Xu from Tsinghua University using GLM-5.1 from Z.ai Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste --- usr.sbin/virtual_oss/virtual_oss/virtual_oss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/virtual_oss/virtual_oss/virtual_oss.c b/usr.sbin/virtual_oss/virtual_oss/virtual_oss.c index 1d95c87d57b1..42a748a5e3bd 100644 --- a/usr.sbin/virtual_oss/virtual_oss/virtual_oss.c +++ b/usr.sbin/virtual_oss/virtual_oss/virtual_oss.c @@ -783,8 +783,8 @@ virtual_oss_process(void *arg __unused) /* check if compressor should be applied */ voss_compressor(buffer_temp, pvp->rx_compressor_gain, - &pvp->rx_compressor_param, samples, - samples * src_chans, (1ULL << (pvp->bits - 1)) - 1ULL); + &pvp->rx_compressor_param, samples * src_chans, + src_chans, (1ULL << (pvp->bits - 1)) - 1ULL); TAILQ_FOREACH(pvc, &pvp->head, entry) {