From owner-freebsd-x11@freebsd.org Tue Mar 19 22:35:03 2019 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34695153E3C5; Tue, 19 Mar 2019 22:35:03 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp.infotel.ru (corp.infotel.ru [195.170.219.3]) by mx1.freebsd.org (Postfix) with ESMTP id AAAB872376; Tue, 19 Mar 2019 22:35:01 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp (corp.infotel.ru [195.170.219.3]) by corp.infotel.ru (Postfix) with ESMTP id D8AE560036; Wed, 20 Mar 2019 01:34:52 +0300 (MSK) X-Virus-Scanned: amavisd-new at corp.infotel.ru Received: from corp.infotel.ru ([195.170.219.3]) by corp (corp.infotel.ru [195.170.219.3]) (amavisd-new, port 10024) with ESMTP id KGQdmqYGBaKl; Wed, 20 Mar 2019 01:34:43 +0300 (MSK) Received: from mail.cicgroup.ru (unknown [195.170.219.74]) by corp.infotel.ru (Postfix) with ESMTP id D469860029; Wed, 20 Mar 2019 01:34:43 +0300 (MSK) Received: from mail.cicgroup.ru (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTP id 7059842211F; Wed, 20 Mar 2019 01:34:42 +0300 (MSK) X-Virus-Scanned: amavisd-new at cicgroup.ru Received: from mail.cicgroup.ru ([127.0.0.1]) by mail.cicgroup.ru (mail.cicgroup.ru [127.0.0.1]) (amavisd-new, port 10024) with SMTP id chvviiyo5hs3; Wed, 20 Mar 2019 01:34:36 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTPA id 6CE0142211C; Wed, 20 Mar 2019 01:34:36 +0300 (MSK) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Wed, 20 Mar 2019 01:34:36 +0300 From: Vladimir Kondratyev To: =?UTF-8?Q?=E8=97=8D=E6=8C=BA=E7=91=8B?= Cc: freebsd-x11@freebsd.org, owner-freebsd-x11@freebsd.org Subject: Re: Which should be used, devel/evdev-proto or /usr/include/dev/evdev? In-Reply-To: <86a3cf16-6206-2a5c-141b-7bfffbd7402f@gmail.com> References: <86a3cf16-6206-2a5c-141b-7bfffbd7402f@gmail.com> Message-ID: X-Sender: vladimir@kondratyev.su User-Agent: Roundcube Webmail/1.3.5 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AAAB872376 X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [4.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.93)[0.934,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[kondratyev.su]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.76)[0.758,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mail.kondratyev.su]; NEURAL_SPAM_LONG(0.81)[0.814,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8299, ipnet:195.170.192.0/19, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.00)[country: RU(0.00)] X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 22:35:03 -0000 On 2019-03-19 19:53, =E8=97=8D=E6=8C=BA=E7=91=8B wrote: > I found evdev-proto, which includes linux/input.h, was added a few > months ago. It seems that many ports has been gradually switched to use > it after it was added. Really, all these ports always had indirect dependency on linux/input.h=20 via RUN_DEPENDS=3Dmultimedia/vl4_compat in libevdev or webcamd Makefile. > However, I also remember there was a patch in > ports to modify GTK3 to use dev/evdev/input.h from base instead of > linux/input.h from ports. I wonder which one should be preferred now. >=20 > The GTK3 patch mentioned above was added about a year ago: > https://svnweb.freebsd.org/changeset/ports/465644 >=20 > After seeing the patch in ports, I submitted it to GTK upstream: > https://gitlab.gnome.org/GNOME/gtk/merge_requests/132 > https://gitlab.gnome.org/GNOME/gtk/merge_requests/133 >=20 > Since software supporting Wayland are likely to require linux/input.h, > is there a policy on dealing with the dependency on linux/input.h? We are trying to mimic Linux evdev API closely, so leave linux/input.h #includes in-place if code is intended to be compiled on Linux too, otherwise use dev/evdev/input.h if it is FreeBSD-only. > It seems to me that evdev-proto was added specifically to address the > issue, so I guess we should just install evdev-proto, stop patching > linux/input.h to dev/evdev/input.h, stop submitting this kind of patch > to upstream projects and tell upstream it is fine to use linux/input.h > on FreeBSD. Is it correct? Yes it is correct. I think, once evdev API becomes stable enough, we=20 could create /usr/include/compat/linux/ directory filled with symlinks to dev/evdev files and nuke evdev-proto port. > _______________________________________________ > freebsd-x11@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-x11 > To unsubscribe, send any mail to "freebsd-x11-unsubscribe@freebsd.org" --=20 WBR Vladimir Kondratyev