From owner-svn-src-head@freebsd.org Fri Feb 23 15:37:32 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21DD6F006DB; Fri, 23 Feb 2018 15:37:32 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x236.google.com (mail-lf0-x236.google.com [IPv6:2a00:1450:4010:c07::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7898B86ABC; Fri, 23 Feb 2018 15:37:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x236.google.com with SMTP id t79so12936227lfe.3; Fri, 23 Feb 2018 07:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4iZb77Gae7fjjbsU3RgBIpmefCLNMMUqgrJNWyZCcFo=; b=eOVCuW4BMlLgel64uyWrE380oxmNrncdna954c5ruZqWNAfFC3rX75Y9au8foOhw0f vTMoiTGZqxGKyd9Ndr+DwEmkWcBEcwpVE1DsJejj1cmREovSjVj2NKmO36MlYiVzOG8i +n7M2okkVn2CKpHYLl4Vc8185seZolot91NhS+Umae2l+181osZgG6nK9KyOBNHuNNM9 okCEaZk7CbZFHsTiThWan8WjfPNOZIg6Iz2wdKMZIYAu44p8vrKXQOKDkUrhImLnoZo4 DAI6ucNyHpccaOwQyomuY8ds8e2F433big2q2xfOo+tdDpJPDhxNkRpcNQfTWByKI58C y6MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4iZb77Gae7fjjbsU3RgBIpmefCLNMMUqgrJNWyZCcFo=; b=keTYKGuiEmzDFi2bwW+HQR4S12f7dSX7QibEluXRebT0v348IsB0nNelJxly4Fz31p gK8SRxb6XEh56pPrIqSqyBI9yL9GEnfHSTQSgMdZfQJapCoqqyET4KZwp1XWXs82g++i xC1oyP/3q65P1xwr2Zc5YJyT7DyUpRlbLxZQmpZkUgVS/Lib1TQYgdChY4GorMkk23uJ 2SOlEWOH6s8OId+bWXrSKIFlE1m9VR9UHQou4DD6VvVadYHlHOisxiQ096lsrJv6Kj47 oS1LGZHXqO/pHceFmfYeK6VEhqz3lEIRCtPME6N16GsvTXNDlkXB3VgNElDpqu1BI9wj ihNQ== X-Gm-Message-State: APf1xPCl/QeiDZgrPNx1Yzn4Hc9P+h3c8u37IDZYZbNJg//dfu14wviE b50N9XY94cBSUhYgGHbrvaJOdyp3t/B4p5wv2VxvWnHp X-Google-Smtp-Source: AG47ELv7pj1j9hLdqUSQ42a29t5cYPgMyq+D5dXQ/I6ZP7KVX0890DLruietPGOW+w0OO6ccb2L3iS/oS+FpgVEf0AI= X-Received: by 10.25.147.219 with SMTP id w88mr1700150lfk.58.1519400249764; Fri, 23 Feb 2018 07:37:29 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.30.66 with HTTP; Fri, 23 Feb 2018 07:37:29 -0800 (PST) In-Reply-To: <201802231447.w1NEl58N096144@pdx.rh.CN85.dnsmgr.net> References: <201802230311.w1N3BhiJ023939@repo.freebsd.org> <201802231447.w1NEl58N096144@pdx.rh.CN85.dnsmgr.net> From: Alan Somers Date: Fri, 23 Feb 2018 08:37:29 -0700 X-Google-Sender-Auth: CQpQd3CB38MuHTi47He6J4w9-wY Message-ID: Subject: Re: svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug To: rgrimes@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 15:37:32 -0000 On Fri, Feb 23, 2018 at 7:47 AM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: asomers > > Date: Fri Feb 23 03:11:43 2018 > > New Revision: 329853 > > URL: https://svnweb.freebsd.org/changeset/base/329853 > > > > Log: > > libifconfig: multiple feature additions > > > > Added the ability to: > > > > * Create virtual interfaces > > * Create vlan interfaces > > * Get interface fib > > * Get interface groups > > * Get interface status > > * Get nd6 info > > * Get media status > > * Get additional ifaddr info in a convenient struct > > * Get vhids > > * Get carp info > > * Get lagg and laggport status > > * Iterate over all interfaces and ifaddrs > > Love that list!!! > > > > And add more examples, too. > > Remove MIT 1996 Copyright? > Under what conditions is it that this is being done? > The file's original author removed the extra license block. It probably shouldn't have been there to begin with. https://github.com/Savagedlight/libifconfig/commit/92fa671bd2451c11c9f1abf68b56295a05af2c85#diff-d2b1298dd60d9c72a5776c8d57a7fe78 > > Note that this is a backwards-incompatible change. But that's ok, > because it's > > a private library. > > > > MFC after: 3 weeks > > Sponsored by: Spectra Logic Corp > > Differential Revision: https://reviews.freebsd.org/D14463 > > With 0 feed back? And a ~30 hour life time? It is not a diffential if > no one looks at, comments on, or accepts the revision. > > Actually, it's been under review for nearly nine months, but on Github, not Phabricator. You see, the original author lacks a commit bit, and has developed this library out-of-tree. It's time we brought it back in, though. I know the Phabricator review didn't last very long, but I have a time limitation on my end. Feel free to tear it apart in post-commit review, if you like. https://github.com/Savagedlight/libifconfig/pull/46 -Alan