Date: Fri, 01 Apr 2016 10:01:42 +0200 From: "John Marino (FreeBSD)" <freebsd.contact@marino.st> To: Thomas Zander <riggs@freebsd.org>, Jan Beich <jbeich@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r412296 - head/lang/rust Message-ID: <7485ef18e1261c87b17a9c23da01259a@secure.marino.st> In-Reply-To: <CAFU734wN13GQnHuXHQ_sW97v9%2Bq3TSYyZPHiqLTjq5HYwO=SAQ@mail.gmail.com> References: <201603312004.u2VK4n5n028013@repo.freebsd.org> <CAFU734wN13GQnHuXHQ_sW97v9%2Bq3TSYyZPHiqLTjq5HYwO=SAQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/1/2016 9:41 AM, Thomas Zander wrote: > Hi Jan, > > On 31 March 2016 at 22:04, Jan Beich <jbeich@freebsd.org> wrote: > >> Author: jbeich >> Log: >> lang/rust: unblock DragonFly build > > While in general I am fine with your commits and your high quality > work, I am not happy at all about the implications in this case. I > don't use DF at the moment, but now we have bits in the port very > specific to DF. This is still "FreeBSD ports" and not > "FreeBSD-and-DF-or-something-else" ports. I will not install a machine > just for the sole purpose of ensuring that rust runs on DF. It's > actually their job to do that, that's why they have specific DF > patches. But now that it is in our official tree, you have enforced a > responsibility upon me to ensure that my next commit won't break the > build on DF, and I won't be able to verify that. > >> Approved by: portmgr "just fix it" blanket > > On this I heavily disagree. The port works on all officially supported > platforms. It is not broken, so it does not need fixing. You > introduced a new feature, namely adding extra bits to support a > non-FreeBSD platform. You should have discussed this with me first. > > Maybe portmgr can comment on this to make it more clear: > - Are we obliged to ensure ports are working on DF? > - Is a commit like this covered by a "just fix it" blanket? (By the > way, where is the "just fix it" blanket documented? I did not find a > recent mail and > https://wiki.freebsd.org/ports-secteam#Blanket_Approval for sure does > not cover this commit.) It's been addressed by portmgr. You are not expected to test fixes on DragonFly, but at the same time you aren't supposed to intentionally break existing DF support. I am allowed to restore builds on DF when updates break them. Why would you take offense that Jan is doing a big service for DF? It doesn't affect you at all or add any new obligations. The home of patches are mixed. If the patches have benefits to FreeBSD (say to support gcc compiler) then they move to ports. If they conflict with FreeBSD somehow, then they stay in dports. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7485ef18e1261c87b17a9c23da01259a>