From owner-freebsd-arm@FreeBSD.ORG  Mon Apr 14 20:58:45 2014
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8F00E265
 for <freebsd-arm@freebsd.org>; Mon, 14 Apr 2014 20:58:45 +0000 (UTC)
Received: from mail1.uj.edu.pl (mail1.uj.edu.pl [149.156.89.193])
 by mx1.freebsd.org (Postfix) with ESMTP id 4D2331A75
 for <freebsd-arm@freebsd.org>; Mon, 14 Apr 2014 20:58:45 +0000 (UTC)
MIME-version: 1.0
Content-transfer-encoding: 7BIT
Content-type: text/plain; CHARSET=US-ASCII; format=flowed
Received: from mbox.uj.edu.pl ([149.156.89.248])
 by mta.uoks.uj.edu.pl (Oracle Communications Messaging Server 7u4-27.01
 (7.0.4.27.0) 64bit (built Aug 30 2012))
 with ESMTP id <0N41002K0GXPA020@mta.uoks.uj.edu.pl> for
 freebsd-arm@freebsd.org; Mon, 14 Apr 2014 22:58:37 +0200 (CEST)
X-Antivirus: Dr.Web (R) for Unix mail servers drweb plugin ver.6.0.2.2
X-Antivirus-Code: 0x100000
Received: from mbox.uj.edu.pl 	by saiph.uoks.uj.edu.pl
 (Dr.Web (R) milter module ver.6.0.2.2)	; Mon, 14 Apr 2014 22:58:37 +0200
Received: from mbox.uj.edu.pl ([149.156.89.248]) by mta.uoks.uj.edu.pl with
 ESMTP; Mon, 14 Apr 2014 22:58:37 +0200 (CEST)
Date: Mon, 14 Apr 2014 22:58:37 +0200
From: Jakub Klama <jakub.klama@uj.edu.pl>
In-reply-to: <534C0F48.2090302@freebsd.org>
Message-id: <f2bebfa812ecb70f423b6be4779b217b@uj.edu.pl>
References: <3e7f866f4bc774975ae3c85e0df78ec2@uj.edu.pl>
 <53418D13.7030107@freebsd.org> <534C0F48.2090302@freebsd.org>
Subject: Re: [RFC] Refactored interrupt handling on ARM
To: freebsd-arm@freebsd.org
User-Agent: Roundcube Webmail/0.5
X-Sender: jakub.klama@uj.edu.pl
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Apr 2014 20:58:45 -0000

 On Mon, 14 Apr 2014 09:39:36 -0700, Nathan Whitehorn wrote:
> This is really nice! One quick question: why have you made
> FDT_MAP_IRQ() a public interface? Shouldn't calling the function it
> maps to just be a private implementation detail in nexus?
> -Nathan

 Well, FDT_MAP_IRQ() existed before my changes and was public. It just
 returned pin and discarded the node parameter:

 #define	FDT_MAP_IRQ(node, pin)	(pin)

 so I left it as is and changed the implementation to route IRQ to
 parent IC.

 Jakub