From owner-freebsd-scsi@FreeBSD.ORG  Wed Apr 17 15:55:47 2013
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 6F6026BE
 for <freebsd-scsi@FreeBSD.org>; Wed, 17 Apr 2013 15:55:47 +0000 (UTC)
 (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id A79F11DE
 for <freebsd-scsi@FreeBSD.org>; Wed, 17 Apr 2013 15:55:43 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
 [212.40.38.101])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA05471
 for <freebsd-scsi@freebsd.org>; Wed, 17 Apr 2013 18:55:35 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Message-ID: <516EC5F7.5030908@FreeBSD.org>
Date: Wed, 17 Apr 2013 18:55:35 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130404 Thunderbird/17.0.5
MIME-Version: 1.0
To: freebsd-scsi@FreeBSD.org
Subject: xpt_schedule_dev: priority of new entry
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Apr 2013 15:55:47 -0000


I wonder what is the reason for the following code:
		/* New entry on the queue */
		if (new_priority < old_priority)
			pinfo->priority = new_priority;

Shouldn't we unconditionally honor new_priority given that this is the new entry case?

-- 
Andriy Gapon