From owner-freebsd-current@FreeBSD.ORG  Tue Dec 27 20:32:14 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B11DE106567A;
	Tue, 27 Dec 2011 20:32:14 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 636D88FC0C;
	Tue, 27 Dec 2011 20:32:14 +0000 (UTC)
Received: from [10.0.0.63] (63.imp.bsdimp.com [10.0.0.63])
	(authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pBRKSisK039899
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Tue, 27 Dec 2011 13:28:46 -0700 (MST) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <20111227010449.GA6244@twoflower.paeps.cx>
Date: Tue, 27 Dec 2011 13:28:44 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <8DD9BAA5-78E0-491A-9E4E-6915B0A9FBAA@bsdimp.com>
References: <20111226101040.GA6361@freebsd.org>
	<20111227010449.GA6244@twoflower.paeps.cx>
To: Philip Paeps <philip@freebsd.org>
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Tue, 27 Dec 2011 13:28:46 -0700 (MST)
Cc: freebsd-current@freebsd.org, current@freebsd.org, freebsd-arch@freebsd.org
Subject: Re: [rfc] removing/conditionalising WERROR= in Makefiles
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Dec 2011 20:32:14 -0000


On Dec 26, 2011, at 6:04 PM, Philip Paeps wrote:

> On 2011-12-26 10:10:40 (+0000), Alexander Best <arundel@freebsd.org> =
wrote:
>> i grep'ed through src/sys and found several places where WERROR=3D =
was set in
>> order to get rid of the default -Werror setting. i tried to remove =
those
>> WERROR=3D overrides from any Makefile, where doing so did not break =
tinderbox.
>>=20
>> in those cases, where it couldn't be completely removed, i added =
conditions to
>> only set WERROR=3D for the particular achitecture or compiler, where =
tinderbox
>> did not suceed without the WERROR=3D.
>=20
> Wouldn't it be better to set WARNS=3Dx rather than WERROR=3D?  WERROR=3D=
 says "this
> code has bugs, it breaks tinderbox" whereas WARNS=3Dx says "this code =
has the
> following kind of bugs which break tinderbox".

Agreed...

> Possibly wrapped in an architecture-test where appropriate.

Not so much...  When you make architecture-specific tests, experience =
has shown that we don't fix bugs and they languish for a long time.  =
Many times, these warnings are real.  Sadly, we've found no way to tag =
the ones that aren't real yet as safe to ignore...

Warner