From owner-freebsd-wireless@FreeBSD.ORG Tue Mar 13 17:30:04 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E7A2C10657A1; Tue, 13 Mar 2012 17:30:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com [209.85.210.45]) by mx1.freebsd.org (Postfix) with ESMTP id 9E0FB8FC21; Tue, 13 Mar 2012 17:30:04 +0000 (UTC) Received: by dadp14 with SMTP id p14so2676277dad.18 for ; Tue, 13 Mar 2012 10:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=exNiL6atR12n3qB5ooDpG5hPb8pNqLrNE7fhrF8Yw3A=; b=NcvV34ezFFcgnORVQuKq3/cQ5/7M9DPeWWwJudF1w4rhKyeqANBudbIs7ZcYFXpxh9 w5TcU9JXrrKCckWlFDcUOdah88zGlzBqmpIuDFrkKU0tFU6XHiXuwFflg3aAHFhSUOrm NHZePzHSSSn3/5WAtUUV1oBBHPwKjGfm6oDnb8YIHX/LUEYOJ2XwdoJ0B7RawlaEyY4G 8TkMwzwZIky0tpmKgmtq5wDP2VswBi9ifkZH3C+2s+cSi0Qhspm1xYCpIDcCvxLI8kes Z3McHDccC3y2WGU+o7AMD0OCaHhrK7ttn6XGSGl7FxMB0NwgvptXptpWVa7jquRDin14 9d+g== MIME-Version: 1.0 Received: by 10.68.232.2 with SMTP id tk2mr7122257pbc.68.1331659804225; Tue, 13 Mar 2012 10:30:04 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.143.33.5 with HTTP; Tue, 13 Mar 2012 10:30:04 -0700 (PDT) In-Reply-To: <20120313111126.GA29538@bali> References: <20120312151358.GA26109@bali> <20120313111126.GA29538@bali> Date: Tue, 13 Mar 2012 10:30:04 -0700 X-Google-Sender-Auth: 8lP0HR-cQvgjMog0ykcZH1zDGRg Message-ID: From: Adrian Chadd To: Andre Albsmeier Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-wireless@freebsd.org" , "freebsd-mobile@freebsd.org" Subject: Re: [Patch] Reflect state of rfkill switch in a sysctl for ath based card X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2012 17:30:05 -0000 On 13 March 2012 04:11, Andre Albsmeier wrote: >> Would you please create a PR and let me know what the PR number is? > > Well, there is a high probability that it might not work on > non-5212 cards end even here it might fail (I can just test > it with this Wistron CM9 card). Maybe someone with more > knowledge about ath(4) (Sam?) might have quick look at it > before... Oh, I'm the ath(4) maintainer now and I'm pretty cluey in this area. The AR5416 and later NICs have a similar looking GPIO rfkill setup but the code isn't yet in the FreeBSD HAL. I have it though, I just haven't ported it from the Atheros reference driver. I'd prefer the rfkill method to be a HAL call, rather than assuming it's a GPIO line. (I mean, it _is_ a GPIO line, but still.) In any case, please create a PR for it now and we'll get it into -HEAD once I've merged in rfkill support for the AR5416 and later NICs. Thanks, Adrian (I work at Atheros now, so..)