From owner-svn-src-head@freebsd.org Sun Nov 5 16:26:48 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 340F9E37558; Sun, 5 Nov 2017 16:26:48 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0114.outbound.protection.outlook.com [104.47.32.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B7D34F1A; Sun, 5 Nov 2017 16:26:41 +0000 (UTC) (envelope-from sjg@juniper.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QDnpKrhuEXM0FaO5SRjNI0DvSfh3M+EEE+DvArXYme0=; b=XhB4+rTh3zsVj7CuiyWKHkfIBlPiXml4l0FMgK8B5d9UFsOBrgDRf2fCDqo6AmQHcONfxJFlx/R2zdYgtoTBvplNQxZ+EZhLmE+fIGDlYjL05Mi5ANtgyXCQTYeZTvxBU27hh+hIUDeoVPvKdT3hZt1r05JKABcx7LMKNiOMTto= Received: from DM5PR05CA0047.namprd05.prod.outlook.com (10.174.188.164) by BY2PR0501MB2069.namprd05.prod.outlook.com (10.163.197.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.218.6; Sun, 5 Nov 2017 16:26:39 +0000 Received: from BY2NAM05FT022.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::206) by DM5PR05CA0047.outlook.office365.com (2603:10b6:4:39::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.218.6 via Frontend Transport; Sun, 5 Nov 2017 16:26:39 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender) Received: from p-emfe01a-sac.jnpr.net (66.129.239.12) by BY2NAM05FT022.mail.protection.outlook.com (10.152.100.159) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P256) id 15.20.197.9 via Frontend Transport; Sun, 5 Nov 2017 16:26:39 +0000 Received: from p-mailhub01.juniper.net (10.47.226.20) by p-emfe01a-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Sun, 5 Nov 2017 08:26:35 -0800 Received: from kaos.jnpr.net (kaos.jnpr.net [172.21.30.60]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id vA5GQZKC015724; Sun, 5 Nov 2017 08:26:35 -0800 (envelope-from sjg@juniper.net) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 7F177385568; Sun, 5 Nov 2017 08:26:35 -0800 (PST) To: Bryan Drewery CC: "O. Hartmann" , , , , Cy Schubert , Subject: Re: svn commit: r325404 - head/share/mk In-Reply-To: <7d0c021d-fe3d-9bea-b088-5e530176288b@FreeBSD.org> References: <201711042102.vA4L2RuR063978@repo.freebsd.org> <20171104223133.00f5bf30@thor.intern.walstatt.dynvpn.de> <20171105111644.4c294342@thor.intern.walstatt.dynvpn.de> <7d0c021d-fe3d-9bea-b088-5e530176288b@FreeBSD.org> Comments: In-reply-to: Bryan Drewery message dated "Sun, 05 Nov 2017 08:00:48 -0800." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13706.1509899195.1@kaos.jnpr.net> Content-Transfer-Encoding: quoted-printable Date: Sun, 5 Nov 2017 08:26:35 -0800 Message-ID: <13707.1509899195@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(376002)(346002)(2980300002)(189002)(24454002)(199003)(6266002)(69596002)(2810700001)(54906003)(97876018)(46406003)(86362001)(47776003)(316002)(105596002)(53416004)(76506005)(93886005)(97736004)(106466001)(9686003)(55016002)(97756001)(6306002)(68736007)(53936002)(117636001)(50226002)(2906002)(77096006)(6246003)(7696004)(478600001)(2950100002)(6916009)(229853002)(189998001)(107886003)(966005)(50466002)(53376002)(5660300001)(4326008)(8746002)(7126002)(23726003)(76176999)(50986999)(356003)(8936002)(81166006)(305945005)(81156014)(8676002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR0501MB2069; H:p-emfe01a-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT022; 1:Jeic1wop5px7wjPEki7RzjXqdYYxEquw9qwLNBs1FuMqWDq6L+at2+s8SqEzQfFgvh6h7yCMuGs2zUb84QSFLdRad7dsAFTFGDD53HdX5S2b22oVy2rcD/eBbIsvnO5E X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04224f04-664d-4133-26c5-08d52469fde0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603249); SRVR:BY2PR0501MB2069; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0501MB2069; 3:xD1sSEKs1BDSRcVSz3x5NT0rN6Sn73tiVwBzO0QfBEzxvuCaWoHtxPinMERni7wOJEZEl/raHcNWlKH/uksWlkxVHve1NzXvWua5fwqc8t9Gy7CoV699m3CkPD24p6h0iohEmGoDF73dtmX7rMIbznDJLoHFvyR/VurauvBa22zu8007dzym36TTY4wc1WvdvbaxwTCPxr9s/l11kLz2197MqXSQkIkvt9fjQwrnhhd2mspdFyv3V1AbPg8iX0ar7A1DCgm6whMTPaZib7dwf0e5N7zdsn1lwHph7sux5aDdc5XsCbkNLqQDpSkrEjg6ubYHM9BHrcy+cj0++EDatImBd+W1sYaiwOtHrihccoQ=; 25:zpHyewJKnxD91rUxgBDrxJVtigKS2u3c6LBV7zFC3vvp0ZUh10tCSZgVoPBRzmPLN9hkhK5Ms+k4Y6tsf2PWDDjPcN72l001GchbAD34BS2/P9fzqbqWTo8kAQQ4fxSQRs051iDLmgKY9vTo2qx6CMF44geE/urdeICWGJI5iQTagYG0aMqT9QkTyqiBULJU4w+GE4uXR4Get8Q8yn05g8V3zgbZZsCsotXAj9b8DHZnxG7vfZFSc2NlIxwR6cFBAymblJP62fkG+oMNHgAWqM1KoOxwKcP/6vS2oS0nGZXoD0QEESpxU6eOjdwCUUd8+QhEbSzpdQnYRikIsjYTHQ== X-MS-TrafficTypeDiagnostic: BY2PR0501MB2069: X-Microsoft-Exchange-Diagnostics: 1; BY2PR0501MB2069; 31:G1MgQ+yUt3cA16fTp4xVE/wy6feLKfKkVzxBsrD9PLZ5OLpS6Idm3dizizW3zja5/2/PEkFPcloba/ekMZaeGH1q0PBTHAJgbZJfE80wpQ9s/wtNKjKIyb4BI/2VWfLsI0MlLevzyWwR446vGtO0L+xzlId9MBxA42L5H7Ex8LtD2X1K+YDU2vb4BnVh3OFAzmFgLbJZF/SZchouArh+B5zUSJv0UwGGAb2DpYZTCI4=; 20:YrQ4l8WikZORuCaX8eqZ7o7VTCW3uO1PgKjdnJt5RlndG7Q4C+J3c+Blbl2/z84hM1Rn7YSsP2FtzU9Xx79slcHYpIvRrlLDqm4hHYBIWZCfypRcc1EuFg6RO9rXXe/SQDC22Dw2S8UCH24yUNVOuAp2SKdH84ngV3QqtNWqgb6Vnne3Dplwm3Edx5/3D9jmsvg7Fbu05Q1Le8iIN6+r6Cgwvq6eAvnZcAhy+GKhleuB3wuz67vzHvmW5GIMwen7TtYyWFiBGD7z7DeCO6tCVHJrcJb/ex7figlxcMonas4QW3VjrOubAjbqhxYSeAgiwEkAjNIjSJ3croWN2mNjOo1i4ifrFutAfg02CDqhPcXFCtSAKQo3ZzRR82jgYp2N90Nqk1dRuS8kezT4Gw29rCSUeeUpdYoPGtQc6hUp6F6qMBLB1IRmMNHBGfEUqyzuN+iPmH/6S8pdiYBzJ1ax8AZOZ38zOaT2I/NZeAEgYx8oK4O6HzA/TFHNKtajxrEg X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231021)(100000703101)(100105400095)(93006095)(93003095)(6055026)(2017110403001)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR0501MB2069; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR0501MB2069; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0501MB2069; 4:aYVjIRIUvQd31/FFkrGDVcn2uycQtUPUrXQ4rxOGH/ZNbsT9ywuv8urjCRik5AhDkVfna9DrIcOz75B99A0kFnif92nLtvRkuFcxQ2Hvm6S/87JTSYaGvAM+qr8JWnbmNvduAE+aLduF1CT2srxlcfhzB/SPO1eh4DkcCSMruOd/JxYWlYQ2g2I+j+N7RCaBJSENmnyGKw3B35OYFum8oMnd402vZx2S6uA0ShT++T2Wyv7A7zSoeQcbgRg5T6irZ+lX1EUL8SUh3Zp24iaDlw== X-Forefront-PRVS: 04825EA361 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0501MB2069; 23:79MYDwfRcI+6VJmT30uKEPChNFSAb64NjLXS/s3?= =?us-ascii?Q?oz4MKumoJ7vltfXKYUk3OO9bShTDx2Xq5cCIvdsZiId1pMwxqzEecKGq0bU8?= =?us-ascii?Q?JjUk9zhgnkWpvJofEefYVpQBpnPTJgCriMVvbV0pMdS8gT4GpbX5OKTpvv86?= =?us-ascii?Q?B1CUenRn9NeKwMylTR6UhulAKHtfDHCEmouJdOvwwRVHEH+LMiNPSvt4+nH0?= =?us-ascii?Q?1i+2MBf6ZtMF5Nj4HOGk6hFZTDldST+hJkHAywG5B2P/F3QUyym2q4aTFl3m?= =?us-ascii?Q?MxfxWWfWtHo+ueYdo6DFUhHx2NYxoFcPMIZdfuHXYNkyybUi/RgqX9WoUMYq?= =?us-ascii?Q?3I3XjKtEQhQ6kx1J66YArRnPjEtMyHy8+mkUG/A04fNHxbileqDVrSaTJOqR?= =?us-ascii?Q?NMdmka/lfzWqyv7uj88X16O83JWPZC/QRodlLHtdNYvzuqd4bNrxbA8XMGvO?= =?us-ascii?Q?CFHs+Phqs4ttNzAUa9+DrZ2SA0Krt+/FsA2/7lF1mfsuFrBh3FSmXN4jToWm?= =?us-ascii?Q?dtRP0SA9fhGGubwCnFCCTBIlv7sNHhm+/8BfxFHTQidLYVdwXTlP9CJnINle?= =?us-ascii?Q?dptsJCh2AHbSKfYh00y3EdGAN/YzpC39d28ZADN6paOWZA9jVfaVRVipvyGW?= =?us-ascii?Q?ZPp621RK2SqnWPdgQwAwHd37JjFVY+GypK7yfE0Iav3r2513GTpQnVf+Ul9t?= =?us-ascii?Q?TGtH9mekCsQLLqCGOwwv2QrZvfDlCVuhtR6MQDviEhFLk6vJXLWexQgIkPTy?= =?us-ascii?Q?L58H1+lVnLCrL4iY/N56IeeVaoP+Ir3pnp2bsLVWZK4VVQ26Fk2F6V/gPVJg?= =?us-ascii?Q?hu5X81Ggzepe/YkCkP1FY2wKLTuqnAhZmxFLYp8sg0kzQD9TKM3tm13meWEO?= =?us-ascii?Q?YhfF5J3fPoF/j9tTKcNvTqOwMZ4iRy+a4aDJqYTbarFL3X0rMAMNalwy3jf4?= =?us-ascii?Q?jljjC7cbo6oUaynaiXpAQ1AvDnddX8aoAgEJbZOvDlYSiexAMRFWBvJv2t6j?= =?us-ascii?Q?cRtJC/ca+TiSv8cGLLXlTmB+sZWba1q+UTkxhAcerqVpYXvAhGeQkEq7xR3H?= =?us-ascii?Q?ahrN463/+vEFcpq7ResSk6/EAmIqlIeTiK0IiNSK9FlGwhq3vVclL/Ln44P1?= =?us-ascii?Q?LiKEtGujiSwrZY668x+CMzN9XuebZ0EdYc0w5LuXLJVuJRJUfvavQJKADnAY?= =?us-ascii?Q?V28GLe6+YLujS60OymJSjg9bhHl+b1YmKkTW+4OH/PzdcFC0a5hBlxvEHTFF?= =?us-ascii?Q?zXyHduhAadbKAPN0biz9/W3F+xIqhK5bDvNQeP1YpCoaP8PCiYsc3hGVpH+N?= =?us-ascii?Q?nu/jcmMfdKF40KcsCox2jIs8=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0501MB2069; 6:OXlugyFmXyf414Ylo+5OMp8heQGBQQKa1kR7dNh8gp9w5rNSBE2/J3xjUJtJ+d11oggurh0TmOpOl+j7BVR/cRop9Qa4AKa6dYyG8BAHigp9JaGELMIS7ZUDyIJfxD8OI9SReynIOsFqG4uNm7rWVDRsOt/sThKLNlKIifU2b2hkRigE8n6jGOMmTeNq9BbSf+PA7jCskvDg07Ynuoa7dNRrUO86O5LEReGWGT+PwWzX3t4L6d20BVmrb1WvP9Z+TD35bTOK4xihKQ7YEA4mHZWRQjdac8j07Ew7jIJcP0SwazkTuhwRto8MKxhRTUnFvKyjXtKwA8vKKRT3PY9mKTngcIXUp/iE59BrY0yi0XU=; 5:GtJCCQwePeapOU6FdgUgGxm23ntq5p7sovlpD9VHfZPNbDbeEAXu+tkyxB7QQcIq/F8aGJdVI+iP9UX4V47QfmwSO9bv4k4UzY3V6rqUHtuI+Q/za3I/8fxPJu0PL1GL4F/Rml+WziDBpp75zY4EXZNY01iWX3QqhDcIYuSoqso=; 24:mqCZlv54HYHnyx1HjLHSUFy6TJ0M3ceaG/GUxpIgnGICByRvnZRhMW2/5xH7XW+8GAfecxa04nRTH0rTBXM7XMF8Vfo8I3Qm+MSGPM+7SJY=; 7:ADmAla4fNVMPXHHMGgZ4yzTiyOjAayacxzM7XCoXYDBZxuoVjLLyBvFswUc46fuz1Yfq2IDn6IhzE32tce4qeiI2NgZyLdYCkWgEVuimZm31mXIGJDrnoone1+w6SEgWiKZkSyUw9zzOdhy8Q52nhf4aXN/hrfqgF+k5pR2yQDXjgIl+Bo/6lR7sVWKiA1RsEAdOU885YRfteTz8E7SKcxNauKK2D6dU7s9ZVz7e9yQp4cktYj72RWGHO1JfnpHZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2017 16:26:39.1191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04224f04-664d-4133-26c5-08d52469fde0 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[p-emfe01a-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0501MB2069 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 16:26:48 -0000 Bryan Drewery wrote: > > ${.OBJDIR} =3D=3D /${RELDIR})) make[6]: Fatal errors encountered -- ca= nnot continue make[6]: > > stopped > > in /usr/obj/usr/src/amd64.amd64/sys/THOR/usr/ports/emulators/virtualbo= x-ose-kmod/work/VirtualBox-5.2.0/out/freebsd.amd64/release/bin/src/vboxdrv > > *** Error code 1 > = > Weird, can you try this please? http://dpaste.com/3HR1EQH.txt > = That will work, but you could remove the check for SRCTOP since it isn't used in the conditional. FWIW this is happening because make is being run from within OBJTOP during kernel module build, and thus the logic in src.sys.env.mk isn't defining RELDIR. If OBJTOP were defined (it is in my case) the following which is similar to what we have in our internal trees would fix it. In the FreeBSD tree though OBJTOP may not defined until some time later. And if you want to .export it you need to use .export-env and play games to get it into a form that will work as TARGET_SPEC_VARS change values. Index: share/mk/src.sys.env.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- share/mk/src.sys.env.mk (revision 325436) +++ share/mk/src.sys.env.mk (working copy) @@ -10,6 +10,8 @@ RELTOP=3D . .elif ${.CURDIR:M${SRCTOP}/*} RELDIR:=3D ${.CURDIR:S,${SRCTOP}/,,} +.elif ${.CURDIR:M${OBJTOP}/*} +RELDIR:=3D ${.CURDIR:S,${OBJTOP}/,,} .endif RELTOP?=3D ${RELDIR:C,[^/]+,..,g} RELOBJTOP?=3D ${RELTOP}