Date: Tue, 2 Jun 2020 08:55:43 +0200 From: =?UTF-8?Q?Lo=c3=afc_Bartoletti?= <lbartoletti@FreeBSD.org> To: Adriaan de Groot <groot@kde.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r536991 - head/net-im/telegram-desktop/files Message-ID: <b4fe0ecf-6f1c-dc6e-baf1-6490012d0f2e@FreeBSD.org> In-Reply-To: <16832933.sFgvYJuXru@beastie.bionicmutton.org> References: <202005291841.04TIft0K071945@repo.freebsd.org> <16832933.sFgvYJuXru@beastie.bionicmutton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thank you! Thanks to you, tobias and the kde/qt5 team for everything that has been done! It's a pleasure to be with you in the team! Loïc Le 29/05/2020 à 22:33, Adriaan de Groot a écrit : > On Friday, 29 May 2020 20:41:55 CEST Loïc Bartoletti wrote: >> Log: >> net-im/telegram-desktop: prepare for Qt5-5.15 >> >> Approved by: tcberner (mentor) >> Differential Revision: https://reviews.freebsd.org/D25051 > Thanks Loïc, it's good to have more people helping with the tidying and > patchwork before a Qt update. > > > For context for other developers: implicitly included header files are a > problem. We all know that from Linux software that assumes that <string.h> > include <errno.h>, that kind of stuff. Qt has similar deeply-hidden implicitly > included headers, and some releases pare them down by introducting forward > declarations. That has annoying fallout all over as the previously implicit > includes need to be made explicit for software written and released against > older Qt versions. The fix is harmless with older Qt, while reducing the size > of the diff when we *do* import Qt 5.15 into the tree. I expect things like > Telegram to have a release some time down the line that makes these patches > obsolete again as the new release is done against the latest released Qt. > > So thanks again, Loïc, for dealing with this drudge-work. > > [ade]
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b4fe0ecf-6f1c-dc6e-baf1-6490012d0f2e>