From owner-svn-ports-all@freebsd.org Tue Jun 2 06:55:45 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7BBBA32C248; Tue, 2 Jun 2020 06:55:45 +0000 (UTC) (envelope-from lbartoletti@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49bjVT2Zqxz43Vm; Tue, 2 Jun 2020 06:55:45 +0000 (UTC) (envelope-from lbartoletti@FreeBSD.org) Received: from imac-de-loic.home (unknown [IPv6:2a01:cb15:218:7c00:8a4:1435:6b71:f29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: lbartoletti) by smtp.freebsd.org (Postfix) with ESMTPSA id C1D4617EBA; Tue, 2 Jun 2020 06:55:44 +0000 (UTC) (envelope-from lbartoletti@FreeBSD.org) Subject: Re: svn commit: r536991 - head/net-im/telegram-desktop/files To: Adriaan de Groot , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202005291841.04TIft0K071945@repo.freebsd.org> <16832933.sFgvYJuXru@beastie.bionicmutton.org> From: =?UTF-8?Q?Lo=c3=afc_Bartoletti?= Message-ID: Date: Tue, 2 Jun 2020 08:55:43 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <16832933.sFgvYJuXru@beastie.bionicmutton.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 06:55:45 -0000 Thank you! Thanks to you, tobias and the kde/qt5 team for everything that has been done! It's a pleasure to be with you in the team! Loïc Le 29/05/2020 à 22:33, Adriaan de Groot a écrit : > On Friday, 29 May 2020 20:41:55 CEST Loïc Bartoletti wrote: >> Log: >> net-im/telegram-desktop: prepare for Qt5-5.15 >> >> Approved by: tcberner (mentor) >> Differential Revision: https://reviews.freebsd.org/D25051 > Thanks Loïc, it's good to have more people helping with the tidying and > patchwork before a Qt update. > > > For context for other developers: implicitly included header files are a > problem. We all know that from Linux software that assumes that > include , that kind of stuff. Qt has similar deeply-hidden implicitly > included headers, and some releases pare them down by introducting forward > declarations. That has annoying fallout all over as the previously implicit > includes need to be made explicit for software written and released against > older Qt versions. The fix is harmless with older Qt, while reducing the size > of the diff when we *do* import Qt 5.15 into the tree. I expect things like > Telegram to have a release some time down the line that makes these patches > obsolete again as the new release is done against the latest released Qt. > > So thanks again, Loïc, for dealing with this drudge-work. > > [ade]