Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Oct 2012 18:09:31 -0700
From:      Devin Teske <devin.teske@fisglobal.com>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, Devin Teske <dteske@freebsd.org>, src-committers@freebsd.org
Subject:   Re: svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share
Message-ID:  <0F57FE3C-EA9C-4763-A8F1-FE2024044D03@fisglobal.com>
In-Reply-To: <20121021181024.GE92674@FreeBSD.org>
References:  <201210181843.q9IIhs6N099621@svn.freebsd.org> <20121019055442.GA9108@FreeBSD.org> <D15CE1CB-E484-4C46-8304-60437EFEBC7D@fisglobal.com> <20121019170216.GB92674@FreeBSD.org> <44662B32-966F-4573-987D-EEE8A07C5A16@fisglobal.com> <20121021181024.GE92674@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Oct 21, 2012, at 11:10 AM, Alexey Dokuchaev wrote:

> On Fri, Oct 19, 2012 at 11:36:04AM -0700, Devin Teske wrote:
>> On Oct 19, 2012, at 10:02 AM, Alexey Dokuchaev wrote:
>>> Ah, I guess it might explain the shitty colors I see on newish FreeBSD
>>> screenshots of dialog(1).
>>=20
>> I actually prefer the colors in cdialog (more specifically, I prefer the
>> lack-of-yellow!).
>>=20
>> I'm curious about how others feel about the use of yellow (specifically
>> that old dialog(1)/libdialog used it a lot and new cdialog-based dialog(=
1)/
>> libdialog doesn't use it hardly at all).
>=20
> While you probably know my opinion at this point, I'd like to remark that=
 our
> original dialog(1) colors seem like one of our distinctive features (simi=
lar
> to e.g. RedHat's or Debian's text-based installers) that had been around =
for
> years and are immediately recognizable.  It is sad to loose them.
>=20

Hmm, you make an interesting point and I think I know why the change in col=
ors.

I saw this hit my inbox recently:

%begin excerpt%
--- head/contrib/dialog/CHANGES	Sun Oct 21 18:18:49 2012	(r241817)
+++ head/contrib/dialog/CHANGES	Sun Oct 21 18:25:12 2012	(r241818)
@@ -1,9 +1,172 @@
--- $Id: CHANGES,v 1.360 2011/07/07 23:35:10 tom Exp $
+-- $Id: CHANGES,v 1.419 2012/07/06 18:18:48 tom Exp $
-- Thomas E. Dickey <dickey@invisible-island.net>

This version of dialog was originally from a Debian snapshot.  I've done th=
is
to it:

%end excerpt%

The dialog(1) that we're using in 9+ was originally from Debian and then "t=
om" makes a bunch of modifications (and I think our own nwhitehorn might ma=
ke some more changes).

I think this explains the [recent] similarity in color choices.

I think you make a good point about diminished diversity. However, I'd inqu=
ire with nwhitehorn about any/all changes to the dialog(1) contrib code as =
it is still vendor maintained (and he's the one doing the importing these d=
ays).



>> It is possible to change the colorings by first creating (if you don't
>> already have one) a ~/.dialogrc by executing the below command:
>>=20
>> dialog --create-rc ~/.dialogrc
>>=20
>> followed by editing said file.
>>=20
>> So while the default look and feel has changed, it's possible to customi=
ze
>> it to your liking.
>=20
> I would wholeheartedly prefer us to have original colors by default, and =
to

Changing the default colors introduces [more] maintenance for the importer/=
maintainer of the contrib code. Exactly how much more maintenance, I'm unsu=
re of.


> provide alternative color scheme for those how experience some difficulti=
es
> with them (e.g. MacOSX users), not the other way around.
>=20

Mac OS X was only one example, and I agree it should not be the sole source=
 of reasoning here. However, I experience the same problem using XTerm nati=
vely on FreeBSD. My personal issue although has already been heard on the t=
opic (unable to see the yellow titles, yellow hlines, or pretty much any ye=
llow on a light background) -- so I'm inclined to not push too hard in rest=
oring the original coloring _exactly_ as it was (read: I think we can do be=
tter).
--=20
Devin

_____________
The information contained in this message is proprietary and/or confidentia=
l. If you are not the intended recipient, please: (i) delete the message an=
d all copies; (ii) do not disclose, distribute or use the message in any ma=
nner; and (iii) notify the sender immediately. In addition, please be aware=
 that any message addressed to our domain is subject to archiving and revie=
w by persons other than the intended recipient. Thank you.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0F57FE3C-EA9C-4763-A8F1-FE2024044D03>