From owner-cvs-all@FreeBSD.ORG  Mon Jan 19 03:42:50 2009
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C8A491065670;
	Mon, 19 Jan 2009 03:42:50 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 83E478FC16;
	Mon, 19 Jan 2009 03:42:50 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from acrux.dbai.tuwien.ac.at (acrux [128.131.111.60])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP id DC44E39113;
	Mon, 19 Jan 2009 04:42:48 +0100 (CET)
Received: by acrux.dbai.tuwien.ac.at (Postfix, from userid 1203)
	id 461E210059; Mon, 19 Jan 2009 04:42:55 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by acrux.dbai.tuwien.ac.at (Postfix) with ESMTP id 19FC210054;
	Mon, 19 Jan 2009 04:42:56 +0100 (CET)
Date: Mon, 19 Jan 2009 04:42:55 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Joe Marcus Clarke <marcus@FreeBSD.org>
In-Reply-To: <200901181849.n0IInwJi009690@repoman.freebsd.org>
Message-ID: <alpine.LSU.1.99.0901190434070.12007@acrux.dbai.tuwien.ac.at>
References: <200901181849.n0IInwJi009690@repoman.freebsd.org>
User-Agent: Alpine 1.99 (LSU 1142 2008-08-13)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/ports-mgmt/portlint Makefile
 ports/ports-mgmt/portlint/src portlint.pl
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2009 03:42:51 -0000

Hi Marcus,

On Sun, 18 Jan 2009, Joe Marcus Clarke wrote:
>   Requested by:   Dominic Fandrey <kamikaze@bsdforen.de> [1]
>                   gerlad [3]

who is that gerlad guy? :-P

Seriously, thanks a lot for the fast reaction to my suggestion.  I never 
would have come up with this code myself, but now that it is there, I 
managed to debug a problem and make some other fixes.  (Checking for 
FCFLAGS instead of FFLAGS was a specification problem in my original
mail, sorry about that.)

Gerald


Commit log:
Check for CONFIGURE_ENV+=, too.  Warn about FFLAGS instead of FCFLAGS 
being passed to CONFIGURE_ENV and rework the associated error message.

--- /usr/local/bin/portlint	2009-01-18 20:24:16.000000000 +0100
+++ x	2009-01-19 04:37:47.132874000 +0100
@@ -1894,7 +1894,7 @@
 	#
 	# whole file: CONFIGURE_ENV
 	#
-	if ($whole =~ /\nCONFIGURE_ENV[?:]?=\s*([^\\\n]+(\\\n[^\\\n]+)*)/) {
+	if ($whole =~ /\nCONFIGURE_ENV[?:+]?=\s*([^\\\n]+(\\\n[^\\\n]+)*)/) {
 		my $configure_env = $1;
 		my $cflags = undef;
 		my $cxxflags = undef;
@@ -1937,10 +1937,10 @@
 
 		if ($configure_env =~ /(FC)=/ ||
 			$configure_env =~ /(F77)=/ ||
-			$configure_env =~ /(FCFLAGS)=/) {
-				&perror("FATAL", $file, -1, "The Fortran flag, $1 is already ".
+			$configure_env =~ /(FFLAGS)=/) {
+				&perror("FATAL", $file, -1, "$1 is already ".
 					"passed in CONFIGURE_ENV via bsd.gcc.mk.  If you need to ".
-					"override the the default value, alter $1 in the Makefile ".
+					"override the default value, alter $1 in the Makefile ".
 					"instead with $1=...");
 		}
 	}