From owner-freebsd-bugs  Wed Apr  2 01:40:09 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id BAA18702
          for bugs-outgoing; Wed, 2 Apr 1997 01:40:09 -0800 (PST)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id BAA18691;
          Wed, 2 Apr 1997 01:40:04 -0800 (PST)
Date: Wed, 2 Apr 1997 01:40:04 -0800 (PST)
Message-Id: <199704020940.BAA18691@freefall.freebsd.org>
To: freebsd-bugs
Cc: 
From: Dan Walters <hannibal@cyberstation.net>
Subject: Re: kern/3104: Cannot execute files on a nullfs filesystem.
Reply-To: Dan Walters <hannibal@cyberstation.net>
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

The following reply was made to PR kern/3104; it has been noted by GNATS.

From: Dan Walters <hannibal@cyberstation.net>
To: freebsd-gnats-submit@freebsd.org, hannibal@cyberstation.net
Cc:  Subject: Re: kern/3104: Cannot execute files on a nullfs filesystem.
Date: Wed, 2 Apr 1997 03:36:01 -0600 (CST)

 I (eventually) managed to figure this one out.  The fix is pretty simple:
 
 Index: src/sys/miscfs/nullfs/null_vnops.c
 ===================================================================
 RCS file: /usr/cvs/src/sys/miscfs/nullfs/null_vnops.c,v
 retrieving revision 1.16
 diff -c -r1.16 null_vnops.c
 *** null_vnops.c	1997/02/22 09:40:22	1.16
 --- null_vnops.c	1997/04/02 09:16:31
 ***************
 *** 330,336 ****
   			goto out;
   		vppp = VOPARG_OFFSETTO(struct vnode***,
   				 descp->vdesc_vpp_offset,ap);
 ! 		error = null_node_create(old_vps[0]->v_mount, **vppp, *vppp);
   	}
   
    out:
 --- 330,337 ----
   			goto out;
   		vppp = VOPARG_OFFSETTO(struct vnode***,
   				 descp->vdesc_vpp_offset,ap);
 ! 		if (*vppp)
 ! 			error = null_node_create(old_vps[0]->v_mount, **vppp, *vppp);
   	}
   
    out:
 
 The problem occurred with the first VOP_BMAP in vnode_pager_haspage(),
 which gives a NULL vpp.  The same change also needs to be made to umapfs,
 I believe unionfs is OK though.
 
 If somebody actually reads this, e-mail me to let me know that I don't
 need to send this to -hackers for someone to see it.  :)
 
 ======================================================================
 Dan Walters
 hannibal@cyberstation.net
 ======================================================================