From owner-svn-ports-all@FreeBSD.ORG  Sun Apr 12 14:30:06 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 56735E6C; Sun, 12 Apr 2015 14:30:06 +0000 (UTC)
Date: Sun, 12 Apr 2015 14:30:06 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Rodrigo OSORIO <rodrigo@freebsd.org>
Subject: Re: svn commit: r383869 - in head/x11/tilda: . files
Message-ID: <20150412143006.GA47927@FreeBSD.org>
References: <201504121406.t3CE6q8f015308@svn.freebsd.org>
 <20150412141020.GA40906@FreeBSD.org> <552A80A0.40706@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <552A80A0.40706@freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Apr 2015 14:30:06 -0000

On Sun, Apr 12, 2015 at 04:26:40PM +0200, Rodrigo OSORIO wrote:
> On 04/12/15 16:10, Alexey Dokuchaev wrote:
> > On Sun, Apr 12, 2015 at 02:06:52PM +0000, Rodrigo Osorio wrote:
> >> New Revision: 383869
> >> URL: https://svnweb.freebsd.org/changeset/ports/383869
> >>
> >> Log:
> >>    Upgrade tilda to latest stable release 1.2.2
> >>    Fix/Rework build
> >>
> >>    PR:		198763
> >>    Submitted by:	rodrigo (maintainer)
> >
> > I don't quite get it: you've submitted a PR as maintainer, only to commit
> > it yourself as a comitter?  Or it should read "approved by" instead?
> 
> Someone sent me a PR to request an update, I did the job and submit the 
> changes with the PR number PR. I put my name as submitter because as 
> said in the committer handbook : "Submitted by: The name and e-mail 
> address of the person that submitted the fix; for developers, just the 
> username on the FreeBSD cluster.". And I did the fix.

I see; it just looks weird in the commit log.

./danfe