From owner-svn-ports-all@FreeBSD.ORG Wed Mar 25 17:01:55 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 244D5393; Wed, 25 Mar 2015 17:01:55 +0000 (UTC) Received: from mail-yh0-x230.google.com (mail-yh0-x230.google.com [IPv6:2607:f8b0:4002:c01::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CB3E733C; Wed, 25 Mar 2015 17:01:54 +0000 (UTC) Received: by yhjf44 with SMTP id f44so14704128yhj.3; Wed, 25 Mar 2015 10:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=jjxv/16rpsVcPhjEMKK1OKiV9LYIzGgKJUF5ehSe2E4=; b=enfzeF4Xy7EWbT/UtewyU9+jNqu+98WdaZnFb1nSJENvsl3kr7iXPURyzxh15MbtJd 4qg7d87gKqVl0nBZnbc2ClBnxXszrKvVN1HD03ZiVrtVd3M9SydRfHS+DntOlPS1dCes +iwYveNEgT0qMCl0SpcQtcSyrKgXOHa7H3N+emimmW2JxH6/cTNr4AEquayYP/cmbZ7A 00bDAYS61IYWIgOcLNbeH+kOS0kHtj/LShu7ZarFuJAl4mDRA7Nw+HHE0sq6xNrC+518 CVloLA/8Wy1XPNJA4wTpS1HDMbFZGGJ+9zrJ/J8A2u4sj9g16VTuKdjeJdSCGeViTSia UePw== X-Received: by 10.52.38.166 with SMTP id h6mr10478064vdk.80.1427302913940; Wed, 25 Mar 2015 10:01:53 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id jr8sm2232329vdb.25.2015.03.25.10.01.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Mar 2015 10:01:52 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 25 Mar 2015 18:01:49 +0100 From: Baptiste Daroussin To: Adam Weinberger Subject: Re: svn commit: r382234 - head/net/dshell Message-ID: <20150325170149.GC63722@ivaldir.etoilebsd.net> References: <201503251525.t2PFP4ET035840@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LKTjZJSUETSlgu2t" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, MANTANI Nobutaka , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 17:01:55 -0000 --LKTjZJSUETSlgu2t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 25, 2015 at 09:48:07AM -0600, Adam Weinberger wrote: > > On 25 Mar, 2015, at 9:25, MANTANI Nobutaka wrote: > >=20 > > Modified: head/net/dshell/Makefile > >=20 > > -BUILD_DEPENDS=3D bash:${PORTSDIR}/shells/bash > > -RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}pygeoip>0:${PORTSDIR}/net/py-pyg= eoip \ > > +BUILD_DEPENDS=3D bash:${PORTSDIR}/shells/bash \ > > + ${PYTHON_PKGNAMEPREFIX}pygeoip>0:${PORTSDIR}/net/py-pygeoip \ > > ${PYTHON_PKGNAMEPREFIX}pycrypto>0:${PORTSDIR}/security/py-pycrypto \ > > ${PYTHON_PKGNAMEPREFIX}dpkt>0:${PORTSDIR}/net/py-dpkt \ > > ${PYTHON_PKGNAMEPREFIX}ipy>0:${PORTSDIR}/net-mgmt/py-ipy \ > > ${PYTHON_PKGNAMEPREFIX}pypcap>0:${PORTSDIR}/net/py-pypcap > > +RUN_DEPENDS=3D ${BUILD_DEPENDS} >=20 > That needs to be > RUN_DEPENDS:=3D ${BUILD_DEPENDS} >=20 > See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/ma= kefile-depend.html (Bottom of section 5.8.2). >=20 > # Adam >=20 Except here is will not and cannot work because :=3D enforces the expansion= right away meaning PYTHON_PKGNAMEPREFIX will be expanded to empty at this time. RUN_DEPENDS=3D ${BUILD_DEPENDS} Is also boggus because any thing adding to BUILD_DEPENDS later on will automatically be added to RUN_DEPENDS anyway Imho this kind of factorisation should be avoided everywhere in the ports t= ree, the comment in PHB should also be modified to say basically don't do that. The right way to factorize safely dependency is to use a 3rd variable: RB_DEPENDS=3D a:b \ c:d BUILD_DEPENDS=3D ${RB_DEPENDS} RUN_DEPENDS=3D ${RB_DEPENDS} Best regards, Bapt --LKTjZJSUETSlgu2t Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlUS6f0ACgkQ8kTtMUmk6ExE6wCdH4gWcIldep3Nvy4Uh+E15rqZ oSgAn2BtPY9+bOeJR514dqVgsZSoWKrB =Tams -----END PGP SIGNATURE----- --LKTjZJSUETSlgu2t--