From owner-cvs-all@FreeBSD.ORG Fri Nov 11 11:37:21 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C01016A420 for ; Fri, 11 Nov 2005 11:37:21 +0000 (GMT) (envelope-from itetcu@people.tecnik93.com) Received: from relay.rdsnet.ro (gimli.rdsnet.ro [193.231.236.70]) by mx1.FreeBSD.org (Postfix) with SMTP id BF9E843D58 for ; Fri, 11 Nov 2005 11:37:18 +0000 (GMT) (envelope-from itetcu@people.tecnik93.com) Received: (qmail 25778 invoked from network); 11 Nov 2005 11:37:14 -0000 Received: from unknown (HELO smtp.rdsnet.ro) (62.231.74.130) by smtp1-133.rdsnet.ro with SMTP; 11 Nov 2005 11:37:14 -0000 Received: (qmail 32369 invoked by uid 89); 11 Nov 2005 11:37:13 -0000 Received: from unknown (HELO it.buh.tecnik93.com) (81.196.204.98) by 0 with SMTP; 11 Nov 2005 11:37:13 -0000 Received: from it.buh.tecnik93.com (localhost [127.0.0.1]) by it.buh.tecnik93.com (Postfix) with ESMTP id CA761BA0E; Fri, 11 Nov 2005 13:36:54 +0200 (EET) Date: Fri, 11 Nov 2005 13:36:54 +0200 From: Ion-Mihai Tetcu To: Vsevolod Stakhov Message-ID: <20051111133654.53679f43@it.buh.tecnik93.com> In-Reply-To: <200511111029.jABATMW9087903@repoman.freebsd.org> References: <200511111029.jABATMW9087903@repoman.freebsd.org> X-Mailer: Sylpheed-Claws 1.9.15 (GTK+ 2.6.10; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.database.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2005 11:37:21 -0000 On Fri, 11 Nov 2005 10:29:21 +0000 (UTC) Vsevolod Stakhov wrote: > vsevolod 2005-11-11 10:29:21 UTC > > FreeBSD ports repository > > Modified files: > Mk bsd.database.mk > Log: > - Use lower in USE_BDB and USE_SQLITE to make tests > - Fix comment about BROKEN > - Fix wrong dependency on sqlite Can we be _consistent_ in respect of the *_DATABASE* variables ? E.g. either WITH_DATABASE_VER= nn or USE_DATABASE= nn as user settable option; BROKEN_WITH_DATABASE (it should be a enumeration and work for all databases); WANT_DATABASE_VERSION= nn; DEFAULT_DATABASE_VER= nn. Why is the default BDB version 4.1 (and not 4.3) ? Can we export for *all* databases DATABASE_VER ? At least of BDB this is necessary since the include path differs depending of the version; having this also simplifies handling what to install and what not, ./configure option, etc. in ports. I'm not criticizing your work and I'll do the patch if you want once how it should be. Thanks, -- IOnut - Unregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" War isn't a good life, but it's life. -- Kirk, "A Private Little War", stardate 4211.8