From nobody Sat Nov 15 21:09:37 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d868M5Ybfz6GyLQ; Sat, 15 Nov 2025 21:09:39 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d868M4rDWz3sx9; Sat, 15 Nov 2025 21:09:39 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763240979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Pylw8e7nzd0ULfObqQyW/s/M6fNvNtjFVAZFCuTEx8=; b=a1h243fnHulqdmFswvYzOxSTf6cxUoJYwiuen1tsK46KeeahIMVPJOD9ODd7Xnh62htuXy s8IXt6nMAWQQBnTlxOnQTfCt+/4KlieoMVgouq/AGSCwbrpAk8vKO+JtILWPI/XfxagMsm TafYH7Ct1v/pjpJuMy8AiE0pKk9SIWdEJKWoU8fYiuPkzp21BfcX5qXV8ZAYxdJMm8IvWZ UUs0Xi7bRdbFKDgcUxkh7MlU5GR5vOVfkfPBRcjlTsGzfbkDjpdfmpVKB01FaTwHKN8dAl 1xDiSfq9THHuf1GN/wr9lzJ9DDR3371qPzZS3zYQh3HyosNY5kazT03NLPzh1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763240979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Pylw8e7nzd0ULfObqQyW/s/M6fNvNtjFVAZFCuTEx8=; b=GnZkfB+Nn3n0kygxpKamDG4QlzoCLKBrxtWLhv1DdvFLdeJXpNUjgmYd1rvucU75HiS76H V7w9U7tpdnHS5RD1Lk+KHZbdjZfhXJ6dZQ/r7FtDgQ9HrUqKyus2wuma95Zl19l7pbtNY8 X9Hz/9uYO2vhuKCY2NgmKAKRJmCLDmG5iQ+nOrV5aUEw1toVaoXP/JjZF6ImM4PneRk9+z +Lt3ZxqDs+kDqWue2H6no37+EHlaX6bFXMVuu1sUQ4+kuFQaz+el+ma48dvPKPM0Db7KwD +YEJTF6r/fMwirLaq8YYgMYLx+pMEzSsbov6yWwkHHXNQa2i6Ak/7PsMonKvJw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763240979; a=rsa-sha256; cv=none; b=ov8omCj5E/3He+Iv3GDuMDdooxhij1Av0mcBIoNwRZVDJwP5f1VUu2VYLZBqtyKfVXrA7c PGdernwGpsSkXyiayVMYkizMdlVXVkivk4A7eaJ5ia2NL5qW4wb8dITWXE+CZaot+B16/k ChlQfB0uQEyegSeqbftZFcFXPnaJaVXCeuvp0zFml+GW9rrhqbAWoZWiYilwDXBTEoHTv3 v9h/MZKoSxnDQtwtrg+TLaLAIxqmwfSx8iF5H6cTWqzMtY3lvmmSg8mdTGnEsSWLzk3Q40 wle5AmWQSMq9Xz4Iv0WwqmcNgwHIC64heFjDF7GSPuQfHE3Eu3Jgsxi+RlezWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from ltc.des.dev (lfbn-nan-1-698-103.w86-236.abo.wanadoo.fr [86.236.35.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4d868M3G7wzCKt; Sat, 15 Nov 2025 21:09:39 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 2B538A5D55; Sat, 15 Nov 2025 22:09:37 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: "Bjoern A. Zeeb" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a615ded5bf2d - main - sys/conf/files: Add iwx driver In-Reply-To: <975p35no-15n8-q8o8-r154-r3517o4o6oqs@mnoonqbm.arg> (Bjoern A. Zeeb's message of "Sat, 15 Nov 2025 21:00:10 +0000 (UTC)") References: <202511150319.5AF3JZxn087193@gitrepo.freebsd.org> <975p35no-15n8-q8o8-r154-r3517o4o6oqs@mnoonqbm.arg> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sat, 15 Nov 2025 22:09:37 +0100 Message-ID: <86346fuhny.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Bjoern A. Zeeb" writes: > Dag-Erling Sm=C3=B8rgrav writes: > > +dev/iwx/if_iwx.c optional iwx \ > > + compile-with "${NORMAL_C} -DIWX_DEBUG=3D1" > > +dev/iwx/if_iwx_debug.c optional iwx \ > > + compile-with "${NORMAL_C} -DIWX_DEBUG=3D1" > Why would we add the debug flag in a default kernel compile? Because the driver doesn't build without it. Feel free to fix that, but don't forget to turn debugging off in the module build as well. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org