From owner-freebsd-arch@FreeBSD.ORG Tue Mar 23 10:12:54 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0BE0E106566C; Tue, 23 Mar 2010 10:12:54 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 788218FC15; Tue, 23 Mar 2010 10:12:53 +0000 (UTC) Received: from outgoing.leidinger.net (pD954FE1C.dip.t-dialin.net [217.84.254.28]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 63AB6844B3D; Tue, 23 Mar 2010 11:12:46 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 6736B527A; Tue, 23 Mar 2010 11:12:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1269339163; bh=rOsiNdV4exvdzLkWd+0LgzOYlJcIq/yVjp0zqsvMd0Q=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=M0w9a2ddrjRX012d8OcHvKi+ZdW+TAVJHRbFSWZGEAGRy986rNtQEbDVSmYUiqWe0 coFG5GCz4M2D4VaGrsI5XGgFLSaB3QUIofwf6rAmx8PXWbT8ZFAsDLPI9V2hKUayDs Xe/5rZpQ+SlbjD0FW1UqIXghO837YgViE3+AntG3kV1iQF0DvD0wUvQwYXBE12Bvqm LyDS2ZrHv2PU1o9RnqfOmxbGyvSEYcRfSmCT0fpqqNdyij0QkSNTYj5wEp/K8qOKiy eUPrNioxAo16HMi8oMNLXFyVjndONe6gKMYT9qbJOy8qW13qFeDumh85FIxOj10qXc XEm3EblvrLksQ== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o2NAChKg048504; Tue, 23 Mar 2010 11:12:43 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Tue, 23 Mar 2010 11:12:43 +0100 Message-ID: <20100323111243.124121qxmpk2c4lc@webmail.leidinger.net> Date: Tue, 23 Mar 2010 11:12:43 +0100 From: Alexander Leidinger To: "M. Warner Losh" References: <20100322.125937.278730673160410010.imp@bsdimp.com> <20100322.130512.864843819464264610.imp@bsdimp.com> <201003221605.24538.jhb@freebsd.org> <20100322.203553.752311254955266835.imp@bsdimp.com> In-Reply-To: <20100322.203553.752311254955266835.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 63AB6844B3D.1F191 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.44, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1269943968.69742@VR3TSwwrIBsvANpb2/+w7Q X-EBL-Spam-Status: No Cc: rwatson@FreeBSD.org, jhb@FreeBSD.org, freebsd-arch@FreeBSD.org Subject: Re: CTF patch for testing/review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2010 10:12:54 -0000 Quoting "M. Warner Losh" (from Mon, 22 Mar 2010 20:35:53 -0600 (MDT)): > In message: <201003221605.24538.jhb@freebsd.org> > John Baldwin writes: > : On Monday 22 March 2010 3:05:12 pm M. Warner Losh wrote: > : > In message: <20100322.125937.278730673160410010.imp@bsdimp.com> > : > M. Warner Losh writes: > : > : In message: <20100322172104.14234yawbsev0sw8@webmail.leidinger.net> > : > : Alexander Leidinger writes: > : > : : Normally we use MK_xxx for things which are opt-in/opt-out. > What about > : > : : using MK_xxx instead of ENABLE_CTF? If people are in favour > of MK_xxx, > : > : : what should the xxx part look like? > : > : > : > : Normally we *TEST* MK_XXX for things which are opt-in/opt-out and > : > : require the user to say WITH_XXX or WITHOUT_XXX if they don't like the > : > : default (or want to ensure they get option XXX, even if we turn it off > : > : by default in the future). The default then gets encoded in > : > : bsd.own.mk, and permeates the FreeBSD build system since we include > : > : that everywhere, directly or indirectly. > : > : > : > : The problem is that bsd.own.mk is not included in sys.mk, nor should > : > : it be. That's why we have the hacky combination of WITH_CTF and > : > : NO_CTF that's there today. > : > : > : > : : Is bsd.kern.mk included in module builds too? > : > : > : > : Yes. > : > > : > One last thing I should have said was that the patch that was posted > : > earlier in the thread looked ok, and likely couldn't be made > : > significantly better due to the bsd.own.mk issue. > : > : I think the patch is a good approach, I just think it needs to > default to not > : enabling CTF by default. Instead, various bsd.foo.mk should selectively > : enable it. > > I should have added that bit as well... And here it is: http://www.leidinger.net/test/ctf2.diff Please pay attention to one XXX comment. Both cases I describe look possible, but I would like to get some more eyes on this issues to not overlook something. I haven't renamed the NO_CTF part yet. Bikeshed: ENABLE_CTF / ADD_CTF / MK_CTF / MK_CTFINFO / MK_CTFINC / ...? Cast your vote please. Bye, Alexander. -- Zapp: There's only one surefire way back into a woman's heart and parts beyond. I speak, of course, of Karaoke. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137