From owner-svn-ports-all@FreeBSD.ORG Sat Sep 15 22:25:11 2012 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7540A106564A; Sat, 15 Sep 2012 22:25:11 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 57F388FC16; Sat, 15 Sep 2012 22:25:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8FMPBAY069072; Sat, 15 Sep 2012 22:25:11 GMT (envelope-from bapt@FreeBSD.org) Received: (from bapt@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8FMPBB6069049; Sat, 15 Sep 2012 22:25:11 GMT (envelope-from bapt@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: bapt set sender to bapt@FreeBSD.org using -f Date: Sun, 16 Sep 2012 00:25:07 +0200 From: Baptiste Daroussin To: Jung-uk Kim Message-ID: <20120915222507.GB13414@ithaqua.etoilebsd.net> References: <201209142202.q8EM2ABa017821@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EuxKj2iCbKjpUGkD" Content-Disposition: inline In-Reply-To: <201209142202.q8EM2ABa017821@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r304300 - in head/java/jamvm: . files X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Sep 2012 22:25:11 -0000 --EuxKj2iCbKjpUGkD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 14, 2012 at 10:02:10PM +0000, Jung-uk Kim wrote: > Author: jkim > Date: Fri Sep 14 22:02:09 2012 > New Revision: 304300 > URL: http://svn.freebsd.org/changeset/ports/304300 >=20 > Log: > - Update to 1.5.4. > - Reset maintainer to java. > - Convert to optionsNG and add license. > - Unbreak sparc64. > =20 > PR: ports/164941 (partial) >=20 [...] > +FFI_CFLAGS!=3D pkgconf libffi --cflags > +FFI_LDFLAGS!=3D pkgconf libffi --libs-only-L This is not a good idea as is because it break make index that way: "Makefile", line 34: warning: "pkgconf libffi --cflags" returned non-zero s= tatus "Makefile", line 35: warning: "pkgconf libffi --libs-only-L" returned non-z= ero status if run on a system without pkgconf installed to fix this part adding "|| :" at the end of the command might be a good id= ea. I suspect (untested) that it may also make the ports fail to build in a particular situation which is, on a system not having yet pkgconf you try to install jamvm. FFI_CFLAGS and FFI_LDFLAGS might in that case be expanded to nothing before pkgconf is installed as a dependency. The right fix should be then imho to patch the jamvm build system to invoke pkgconf libffi itself. regards, Bapt --EuxKj2iCbKjpUGkD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlBVAEMACgkQ8kTtMUmk6EzHnACgqsStxg2vcHEzdeWSphvd3Na9 V00AoKTCESx7ccCCwDCpGFqL/eJPCEB9 =j65j -----END PGP SIGNATURE----- --EuxKj2iCbKjpUGkD--