From owner-svn-src-all@FreeBSD.ORG Sun Dec 7 13:51:03 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7CB1EFDA; Sun, 7 Dec 2014 13:51:03 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 3189235D; Sun, 7 Dec 2014 13:51:01 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA18028; Sun, 07 Dec 2014 15:52:53 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1XxcEk-0005G1-UW; Sun, 07 Dec 2014 15:50:58 +0200 Message-ID: <54845AF1.8020208@FreeBSD.org> Date: Sun, 07 Dec 2014 15:49:37 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Warner Losh , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r266566 - head/usr.bin/bmake References: <201405230020.s4N0KiLx086859@svn.freebsd.org> In-Reply-To: <201405230020.s4N0KiLx086859@svn.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Dec 2014 13:51:03 -0000 On 23/05/2014 03:20, Warner Losh wrote: > Author: imp > Date: Fri May 23 00:20:44 2014 > New Revision: 266566 > URL: http://svnweb.freebsd.org/changeset/base/266566 > > Log: > Add .../share/mk to the default system make path. This will fix the > problem with broken in-tree builds (which are used far more > pervasively than I'd known outside the tree). However, weird results > may now happen if at any point in the tree above you there happens to > be a directory that has subdirectory of share/mk, as unpredictable > results will follow. This was considered the lessor of the two evils, > at least for now. In the future this will be removed again when the > underlying issues are resolved. Just in case, a concrete example of a possible problem. If a ports tree is placed somewhere below /usr/local and devel/bmake is installed then /usr/local/share/mk/sys.mk would be used instead of /usr/share/mk/sys.mk during port builds. And the former looks nothing like the latter. > Modified: > head/usr.bin/bmake/Makefile > > Modified: head/usr.bin/bmake/Makefile > ============================================================================== > --- head/usr.bin/bmake/Makefile Thu May 22 23:38:17 2014 (r266565) > +++ head/usr.bin/bmake/Makefile Fri May 23 00:20:44 2014 (r266566) > @@ -166,7 +166,6 @@ accept test: > # override some simple things > BINDIR= /usr/bin > MANDIR= /usr/share/man/man > -DEFAULT_SYS_PATH= /usr/share/mk > > # make sure we get this > CFLAGS+= ${COPTS.${.IMPSRC:T}} > -- Andriy Gapon