From owner-svn-src-all@freebsd.org Thu Oct 8 01:39:05 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD0F39D0678; Thu, 8 Oct 2015 01:39:05 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 94D246BC; Thu, 8 Oct 2015 01:39:05 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 8DC4B1561; Thu, 8 Oct 2015 01:39:05 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 3B4E0152CC; Thu, 8 Oct 2015 01:39:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 3TOuIOWWdVbj; Thu, 8 Oct 2015 01:39:02 +0000 (UTC) Subject: Re: svn commit: r288911 - head/share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 73714152C7 To: Warner Losh References: <201510060418.t964Innu071170@repo.freebsd.org> <56140CAD.8080200@FreeBSD.org> <8D5D1CE5-BC57-464D-9C47-63EFF4C1CF2F@bsdimp.com> Cc: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <5615C935.2060204@FreeBSD.org> Date: Wed, 7 Oct 2015 18:39:01 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <8D5D1CE5-BC57-464D-9C47-63EFF4C1CF2F@bsdimp.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GO7rOjJfS2l40apc9Swudr4BHuCWbTl7x" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 01:39:05 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GO7rOjJfS2l40apc9Swudr4BHuCWbTl7x Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/6/2015 1:24 PM, Warner Losh wrote: >> With the META_MODE changes, sjg introduced this /etc/src-env.conf file= >> that is included from sys.mk early, that can be used for overriding >> things like MAKEOBJDIRPREFIX, enabling META_MODE (it needs to be set >> extremely early for AUTO_OBJ support, among other things). >> >> As far as I can tell, the sys.mk change to include src.conf early was >> done out of convenience. Meaning, we could remove that and just add >> back a .include or similar at the top of all src Makefil= es. > All src makefiles? Yea, I=E2=80=99d rather hoped to avoid that, though = it is easily > scripted. I=E2=80=99d thought of this solution at the time I did the MA= KESYSPATH > hack, and rejected it as being too unwieldy. And having that at the top= > of all the files would still require MAKESYSPATH need to be =E2=80=A6/s= hare/mk > to work out. I was rather hoping we could find some good way around > doing that. r289000 confuses me. Clearly src.opts.mk is still needed in Makefiles. So why are we including src.conf in sys.mk and not src.opts.mk? --=20 Regards, Bryan Drewery --GO7rOjJfS2l40apc9Swudr4BHuCWbTl7x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWFck2AAoJEDXXcbtuRpfP3PsIAJfi1TuIRAI+xwKngm1jf2tw H8wD9sp+3cb40joqQyEcDR8pEd5mcnz75WCPOrkNMonG6lSVw+rlK4to2QRTRUMQ ML5eFaj/1PM2sdpLRLZUnNdVHievVZRKzIedxa6KqkZZGgBvT7OGWz5grhPcbT5B qyL+bzLgjAad5tle6zhTM3jHQqfDolEsWn33nOvj9131Eb4Ia7R+k4wNNQ9vVxJ+ XOVARkO2kAphwmMq96ph9KobRPZEfPfP697Jg7hZ2lLKtNxFKf4YNYI2dRIBA6+i cYJkpkjzOsOfSfB6VCjD+fyBdApGU6DwFURkw88WLNhaDhrtWtxk0daCiTxefaI= =5Y83 -----END PGP SIGNATURE----- --GO7rOjJfS2l40apc9Swudr4BHuCWbTl7x--