From nobody Sun Sep 29 09:53:10 2024 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XGffC6PShz5XRJf for ; Sun, 29 Sep 2024 09:53:23 +0000 (UTC) (envelope-from kp@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XGffC5ndmz4DF7; Sun, 29 Sep 2024 09:53:23 +0000 (UTC) (envelope-from kp@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727603603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oDZZj2Eki+6JCyw+ToYdRxkjGuDToP4rYRxjzDwQtzk=; b=C8IY1maJN9oe6cDf9/zTgYJaTfmrmlYiVIC/CyABSc7yaUK/+3zpG2BqOx6QIcERtYz8+D kJxf1uP+WmcEWl0xzgJvGIMQflZKlf0lkqXme/Yd4QEhemkrcwWtrF9K73PumQ0/pdJagZ kHGVQDQtdxBXnJA3pSd3pDIMCtSeIc7jE1OOzo4ZTTJnv0A028e1Hbib9BcbR0+Xw3jeVi UHh/K/gRFWHeqEmSOUHWSmH5SIWlU/J2qhhwLWP6gnmOg+N6KZbo6Swnp8YOYcsO5IykUM lMh4fM5vRaDa3JXpJHIYRj48wLUtZ2uihOdNJteyS94aXW24P+8Ex6wlGQEr8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727603603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oDZZj2Eki+6JCyw+ToYdRxkjGuDToP4rYRxjzDwQtzk=; b=M+4/WDgvmIuftUCXrWBxZVWwZ/22LVmApQGyAAqQWi4AQZA4revgpuKtijfc6L+eBR60em 7ijFYFwp9KBvX/ZS8x083M7ZGeaJgeABO+0JzHQgD9ibmb8Y14OADeDYk+u5Bw8LofCiRa u2R3+9NKoRWnIdzqBd1zDqDsi6ARFz5Ov/8f8Kzs1akJH26/8sKiCGGipJmVDbwHxDDiFA DG5FoCSSgY2ifMuXGlQxNl/q9eMlSrdAi5Mca70LU7jn3LyUibmwcFhP9nmAk3gOTPVQGB fc0QWOzCueTh8fIjNFo/Fekcv7i3NALNyGANpwdQfxmiYZPSLrcgfq7NJ71klg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727603603; a=rsa-sha256; cv=none; b=nARGHxytBmog3Z3HTBanuNo0DB7v5yxNqGSFM4neHQjOwcKjNYXaxxn/eEjLsgyNYb8Ldy 4ntiELXIv7nYeU2F43ZsU4kFi3eM056pvkmTn8v+WavKSsDySKT3kXEYDB+bKnKzXkV9hF /kzU3Vym0yFX7MgawJpmn2ONuYnCJuv8jviZ09+7Ztwb1Tu82Xel0nADH+wbMx6OdkQhBR hu/lLaCVb1nI+mEMR65T1WdeQoe11Us+Rsf9WKKmTHYDy4Dk0h2ATSw6c+dtPFVLufOwD6 fTUKTlsZT9YhRp0Asz5MkKKcRGYASr+d36ZH11vk90FSz4O7NY/f6zmILyiJHQ== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R11" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XGffC4fn2zybd; Sun, 29 Sep 2024 09:53:23 +0000 (UTC) (envelope-from kp@freebsd.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 9D5DC5188F; Sun, 29 Sep 2024 11:53:21 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Kristof Provost List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 (1.0) Subject: Re: Is INET6 a required option these days? (kernel build failure) Date: Sun, 29 Sep 2024 11:53:10 +0200 Message-Id: <01A54634-1A79-4B52-96C4-88253725910C@freebsd.org> References: <4E5CBF78-A9AC-4D1C-9D81-CB379C408468@FreeBSD.org> Cc: Gary Jennejohn , Ian FREISLICH , FreeBSD Current In-Reply-To: <4E5CBF78-A9AC-4D1C-9D81-CB379C408468@FreeBSD.org> To: Zhenlei Huang X-Mailer: iPhone Mail (22A3354) > On 29 Sep 2024, at 04:46, Zhenlei Huang wrote: >=20 > =EF=BB=BF >=20 >> On Sep 27, 2024, at 6:07 PM, Gary Jennejohn wrote: >>=20 >>> On Thu, 26 Sep 2024 14:58:40 -0400 >>> Ian FREISLICH wrote: >>>=20 >>> Lately there have been a couple of commits that fail to build because v6= being compiled in despite INET6 being undefined. I think the latest is 905d= b4aa88775865097714c170f4503da385747c. >>>=20 >>> /usr/src/sys/netpfil/pf/pf.c:8762:38: error: no member named 'icmp6' in '= union pf_headers'; did you mean 'icmp'? >>> 8762 | if (!pf_pull_hdr(m, *off, &pd->hdr.icmp6, icmp_hl= en, >>>=20 >>> Ian >>>=20 >>=20 >> This happens now and then because most committers have INET6 enabled and >> they forget that INET6 is an option and not mandatory. >=20 > Kristof is landing lots of commits from upstream ( OpenBSD ), so we need b= e patient with him ... >=20 There may have been intermittent breakage, although I always try to avoid th= at, but main currently just works.=20 >>=20 >> I don't have INET6 enabled and have reported a number of problems in the >> source as a result of that. I strongly advise against running non-default configurations. They=E2=80=99r= e always less tested (and thus more buggy) and harder to support.=20 Only do so if there=E2=80=99s genuinely no alternative.=20 Best regards, Kristof